In Memoriam: Hans Petter Selasky
ClosedPublic
Actions

Authored by jpb_jimby.name on Mar 3 2025, 3:07 PM.

Details

Reviewers

gallatin
carlavilla
mhorne
ziaee

Group Reviewers

docs

Commits

R9:b7652065c4c7: In Memoriam: Hans Petter Selasky

Diff Detail

Repository

R9 FreeBSD doc repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jpb_jimby.name requested review of this revision.Mar 3 2025, 3:07 PM

jpb_jimby.name created this revision.

Harbormaster completed remote builds in B62739: Diff 151786.Mar 3 2025, 3:07 PM

I followed the new instructions in https://docs.freebsd.org/en/books/fdp-primer/structure/#_managing_contributor_lists

If there are errors or additional files that need editing please advise and I'll correct the above procedure.

I believe that we also want to add him to contrib-develalumni.adoc

In D49215#1122462, @lwhsu wrote:

I believe that we also want to add him to contrib-develalumni.adoc

and can also remove him from the additional contributors, as clearly the procedure for new committers was not followed.

lwhsu added inline comments.Mar 3 2025, 5:20 PM

documentation/content/en/articles/contributors/contrib-develinmemoriam.adoc
17	I guess we want an empty line after this.
shared/authors.adoc
1367	what's the purpose of this leading `\`?

dbaio added inline comments.Mar 3 2025, 5:28 PM

shared/authors.adoc
1367	I have pointed out this to avoid creating the email link "mailto:", as it was did for others

lwhsu added inline comments.Mar 3 2025, 5:57 PM

shared/authors.adoc
1367	I have pointed out this to avoid creating the email link "mailto:", as it was did for others Oh cool, didn't know it. Although we still show full email and crawlers don't really care about mailto: or not, but still looks nice.

In D49215#1122462, @lwhsu wrote:

I believe that we also want to add him to contrib-develalumni.adoc

Done.

documentation/content/en/articles/contributors/contrib-develinmemoriam.adoc
17	I followed the convention in the rest of the file. There is no empty line between bulleted list entries. However, Asciidoctor provides a line during rendering.

In Memoriam: Hans Petter Selasky

Harbormaster completed remote builds in B62745: Diff 151820.Mar 3 2025, 8:42 PM

Changes for Hans Petter Selasky are complete.

Please commit Hans. Thanks.

@gallatin, sir sorry to trouble you, if this memoriam is acceptable to you, with the permission of my mentors I will merge this.

ziaee accepted this revision.Mar 13 2025, 10:04 PM

gallatin accepted this revision.Mar 14 2025, 5:34 PM

This revision is now accepted and ready to land.Mar 14 2025, 5:34 PM

In D49215#1125347, @ziaee wrote:

@gallatin, sir sorry to trouble you, if this memoriam is acceptable to you, with the permission of my mentors I will merge this.

Approved for you to commit @ziaee.

carlavilla accepted this revision.Mar 17 2025, 6:08 PM

Closed by commit R9:b7652065c4c7: In Memoriam: Hans Petter Selasky (authored by jpb_jimby.name, committed by ziaee). · Explain WhyMar 17 2025, 9:38 PM

This revision was automatically updated to reflect the committed changes.

ziaee added a commit: R9:b7652065c4c7: In Memoriam: Hans Petter Selasky.