Page MenuHomeFreeBSD
Differential D48464

libbe: avoid copying encryption-related props
ClosedPublic
Actions

Authored by kevans on Jan 15 2025, 3:27 PM.
Tags
None
Referenced Files
F170822901: D48464.id.diff
Sun, Sep 6, 8:41 PM
F170773920: D48464.diff
Sun, Sep 6, 1:39 PM
F170750295: D48464.id.diff
Sun, Sep 6, 10:01 AM
Unknown Object (File)
Sun, Sep 6, 5:46 AM
Unknown Object (File)
Sat, Sep 5, 5:01 AM
Unknown Object (File)
Fri, Sep 4, 6:45 PM
Unknown Object (File)
Fri, Sep 4, 8:31 AM
Unknown Object (File)
Fri, Sep 4, 2:58 AM
View All Files
Subscribers
imp

Details

Reviewers
arrowd
allanjude
rcm
Commits
rG181549c37f19: libbe: avoid copying encryption-related props
Summary

libzfs insists that these be cloned from the origin, so avoid making a
deep copy of them ourselves to unbreak creating a new BE from an
encrypted BE.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans created this revision.Jan 15 2025, 3:27 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 15 2025, 3:27 PM
kevans requested review of this revision.Jan 15 2025, 3:27 PM
Harbormaster completed remote builds in B61734: Diff 149292.Jan 15 2025, 3:27 PM
arrowd added a comment.Jan 15 2025, 6:32 PM

I can confirm this fixed the problem for me.

arrowd added a comment.Feb 10 2025, 7:59 PM

Can we get this in?

arrowd added a comment.Feb 26 2025, 4:25 PM

Another bump. This is a useful change that we're using at $WORK for quite a time.

allanjude accepted this revision.Feb 26 2025, 4:55 PM

Otherwise looks good to me.

I am interesting in your use case, how are you using encrypted datasets as part of a boot environment without support in the boot loader? Or is it only for children of the root filesystem (nested under the BE)?

lib/libbe/be.c
692

We should have a fallthrough annotation here I think, to make it obvious it is going to go down to the return (ZPROP_CONT); under CANMOUNT

This revision is now accepted and ready to land.Feb 26 2025, 4:55 PM
arrowd added a comment.Feb 26 2025, 7:05 PM

Or is it only for children of the root filesystem (nested under the BE)?

Yes, it is a child of a user's home dataset, which is encrypted.

Closed by commit rG181549c37f19: libbe: avoid copying encryption-related props (authored by kevans). · Explain WhyFeb 26 2025, 10:24 PM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rG181549c37f19: libbe: avoid copying encryption-related props.
kevans added a comment.Feb 26 2025, 10:25 PM
In D48464#1120848, @arrowd wrote:

Or is it only for children of the root filesystem (nested under the BE)?

Yes, it is a child of a user's home dataset, which is encrypted.

I fixed the commit message to more clearly depict the affected setup.

arrowd added a comment.Feb 27 2025, 5:35 AM

Thanks for fixing this for me!

Revision Contents
Changeset List

PathSize
lib/
libbe/
14 lines

Diff 151536

View Options

lib/libbe/be.c

Loading...