Differential D5914

Get rid of rctl_lock.
ClosedPublic
Actions

Authored by trasz on Apr 11 2016, 2:56 PM.

Details

Reviewers

mjg

Commits

rS298414: Get rid of rctl_lock; use racct_lock where appropriate. The fast paths

Summary

Get rid of rctl_lock, using racct_lock where appropriate. The fast paths
already required both of them.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3217
Build 3250: arc lint + arc unit

Event Timeline

trasz updated this revision to Diff 15083.Apr 11 2016, 2:56 PM

trasz retitled this revision from to Get rid of rctl_lock..

trasz updated this object.

trasz edited the test plan for this revision. (Show Details)

Herald added a subscriber: imp. · View Herald TranscriptApr 11 2016, 2:56 PM

trasz added a reviewer: mjg.Apr 11 2016, 2:59 PM

Regenerate.

It seems it should work.

Is this a step towards fine-grained locking?

Could you mark it accepted?

As for the fine-grained locking - not yet. It's just simplification; having two locks like this just doesn't buy us anything.

mjg accepted this revision.Apr 20 2016, 9:50 PM

mjg edited edge metadata.

This revision is now accepted and ready to land.Apr 20 2016, 9:50 PM

Closed by commit rS298414: Get rid of rctl_lock; use racct_lock where appropriate. The fast paths (authored by trasz). · Explain WhyApr 21 2016, 4:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_racct.c

72 lines

kern_rctl.c

112 lines

sys/

racct.h

6 lines

Diff 15083

View Options

sys/kern/kern_racct.c

View Options

sys/kern/kern_rctl.c

View Options

Get rid of rctl_lock.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 15083

sys/kern/kern_racct.c

sys/kern/kern_rctl.c

sys/sys/racct.h

Get rid of rctl_lock.
ClosedPublic
Actions

Revision Contents
Changeset List