Page MenuHomeFreeBSD
Differential D5914

Get rid of rctl_lock.
ClosedPublic
Actions

Authored by trasz on Apr 11 2016, 2:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 14, 11:50 PM
Unknown Object (File)
Tue, Oct 14, 5:59 AM
Unknown Object (File)
Fri, Oct 10, 11:37 PM
Unknown Object (File)
Fri, Oct 10, 10:16 AM
Unknown Object (File)
Sat, Oct 4, 4:56 PM
Unknown Object (File)
Sat, Oct 4, 12:43 PM
Unknown Object (File)
Tue, Sep 30, 11:58 PM
Unknown Object (File)
Sep 17 2025, 2:58 PM
View All Files
Subscribers
imp

Details

Reviewers
mjg
Commits
rS298414: Get rid of rctl_lock; use racct_lock where appropriate. The fast paths
Summary

Get rid of rctl_lock, using racct_lock where appropriate. The fast paths
already required both of them.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz updated this revision to Diff 15083.Apr 11 2016, 2:56 PM
trasz retitled this revision from to Get rid of rctl_lock..
trasz updated this object.
trasz edited the test plan for this revision. (Show Details)
Herald added a subscriber: imp. · View Herald TranscriptApr 11 2016, 2:56 PM
trasz added a reviewer: mjg.Apr 11 2016, 2:59 PM
trasz updated this revision to Diff 15264.Apr 16 2016, 1:04 PM

Regenerate.

mjg edited edge metadata.Apr 20 2016, 2:36 AM

It seems it should work.

Is this a step towards fine-grained locking?

trasz added a comment.Apr 20 2016, 12:37 PM

Could you mark it accepted?

As for the fine-grained locking - not yet. It's just simplification; having two locks like this just doesn't buy us anything.

mjg accepted this revision.Apr 20 2016, 9:50 PM
mjg edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2016, 9:50 PM
Closed by commit rS298414: Get rid of rctl_lock; use racct_lock where appropriate. The fast paths (authored by trasz). · Explain WhyApr 21 2016, 4:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
kern/
72 lines
112 lines
sys/
6 lines

Diff 15447

View Options

head/sys/kern/kern_racct.c

Loading...
View Options

head/sys/kern/kern_rctl.c

Loading...
View Options

head/sys/sys/racct.h

Loading...