Page MenuHomeFreeBSD
Differential D48309

netlink: fix size comparison
ClosedPublic
Actions

Authored by glebius on Jan 3 2025, 6:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 29, 1:09 AM
Unknown Object (File)
Wed, Nov 26, 4:47 PM
Unknown Object (File)
Tue, Nov 25, 5:25 PM
Unknown Object (File)
Sat, Nov 22, 12:44 PM
Unknown Object (File)
Thu, Nov 6, 7:44 AM
Unknown Object (File)
Thu, Nov 6, 4:40 AM
Unknown Object (File)
Thu, Nov 6, 4:29 AM
Unknown Object (File)
Mon, Nov 3, 5:08 AM
View All 55 Files
Subscribers
imp
markj

Details

Reviewers
melifaro
markj
Group Reviewers
network
Commits
rGbbe6559cf958: netlink: fix size comparison
Summary

We want to check the size of the header, not a pointer to it.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61488
Build 58372: arc lint + arc unit

Event Timeline

glebius created this revision.Jan 3 2025, 6:29 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 3 2025, 6:29 PM
glebius requested review of this revision.Jan 3 2025, 6:29 PM
Harbormaster completed remote builds in B61488: Diff 148744.Jan 3 2025, 6:29 PM
glebius added a parent revision: D48308: netlink: add snl(3) primitive to obtain group ID.Jan 3 2025, 6:29 PM
glebius added a child revision: D48310: netlink: snl_create_genl_msg_request() may fail due to ENOMEM.
markj accepted this revision as: markj.Jan 3 2025, 6:32 PM
markj added a subscriber: markj.
markj added inline comments.
sys/netlink/netlink_generic.c
70

It's nicer IMO to use sizeof(*hdr), although netlink is inconsistent about this.

This revision is now accepted and ready to land.Jan 3 2025, 6:32 PM
glebius added inline comments.Jan 3 2025, 6:43 PM
sys/netlink/netlink_generic.c
70

I personally prefer sizeof(type) when coding protocols that exchange data, cause a protocol specification talks about types not about our local variable names. That makes it easier to check that code follow protocol spec. For other cases I prefer sizeof(*var), cause var type may change, and often does.

melifaro accepted this revision as: melifaro.Jan 10 2025, 8:35 PM
Closed by commit rGbbe6559cf958: netlink: fix size comparison (authored by glebius). · Explain WhyJan 11 2025, 5:01 AM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rGbbe6559cf958: netlink: fix size comparison.

Revision Contents
Changeset List

PathSize
sys/
netlink/
3 lines

Diff 148744

View Options

sys/netlink/netlink_generic.c

Loading...