Page MenuHomeFreeBSD

netlink: fix size comparison
ClosedPublic

Authored by glebius on Jan 3 2025, 6:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 10, 4:33 AM
Unknown Object (File)
Sat, Jan 10, 4:33 AM
Unknown Object (File)
Sat, Jan 10, 4:25 AM
Unknown Object (File)
Fri, Jan 2, 7:23 PM
Unknown Object (File)
Sun, Dec 28, 1:12 AM
Unknown Object (File)
Wed, Dec 24, 5:02 AM
Unknown Object (File)
Nov 29 2025, 1:09 AM
Unknown Object (File)
Nov 26 2025, 4:47 PM
Subscribers

Details

Summary

We want to check the size of the header, not a pointer to it.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj added a subscriber: markj.
markj added inline comments.
sys/netlink/netlink_generic.c
70–71

It's nicer IMO to use sizeof(*hdr), although netlink is inconsistent about this.

This revision is now accepted and ready to land.Jan 3 2025, 6:32 PM
sys/netlink/netlink_generic.c
70–71

I personally prefer sizeof(type) when coding protocols that exchange data, cause a protocol specification talks about types not about our local variable names. That makes it easier to check that code follow protocol spec. For other cases I prefer sizeof(*var), cause var type may change, and often does.

This revision was automatically updated to reflect the committed changes.