Page MenuHomeFreeBSD
Differential D48077

include: add a userland version of __assert_unreachable
ClosedPublic
Actions

Authored by kevans on Dec 14 2024, 5:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 27, 1:08 AM
Unknown Object (File)
Wed, Nov 12, 10:08 PM
Unknown Object (File)
Thu, Nov 6, 10:48 PM
Unknown Object (File)
Thu, Nov 6, 7:21 PM
Unknown Object (File)
Thu, Nov 6, 6:47 AM
Unknown Object (File)
Thu, Nov 6, 5:53 AM
Unknown Object (File)
Thu, Nov 6, 3:59 AM
Unknown Object (File)
Wed, Nov 5, 11:33 PM
View All 94 Files
Subscribers
christos
collin.funk1_gmail.com

Details

Reviewers
emaste
imp
jhb
olce
Commits
rG235fe911df59: include: add a userland version of __assert_unreachable
rG712f81feea41: include: add a userland version of __assert_unreachable
Summary

The kernel has had a version of this since
c79cee71363d ("kernel: provide panicky version of unreachable"), and
userland can benefit from the same. unreachable is largely
inadequate because it's *not* an assertion of any sort, so we're not
really alerted to a problem that we could've anticipated.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61155
Build 58039: arc lint + arc unit

Event Timeline

kevans requested review of this revision.Dec 14 2024, 5:26 AM
kevans created this revision.
Harbormaster completed remote builds in B61155: Diff 147953.Dec 14 2024, 5:26 AM
kevans added a child revision: D48078: nvmf: fix build with __assert_unreachable() addition to userland.Dec 14 2024, 5:27 AM
imp accepted this revision.Dec 14 2024, 5:32 AM
This revision is now accepted and ready to land.Dec 14 2024, 5:32 AM
jhb accepted this revision.Dec 17 2024, 2:17 PM
emaste accepted this revision.Dec 17 2024, 2:18 PM
olce accepted this revision.Dec 17 2024, 2:31 PM
christos added a subscriber: christos.Jan 12 2025, 9:45 PM
christos mentioned this in D47932: sound: Refactor the format conversion framework.Jan 12 2025, 9:50 PM
christos added a child revision: D47932: sound: Refactor the format conversion framework.Jan 12 2025, 9:51 PM
christos added a child revision: D48421: sound: Turn clamp macros into a function.Jan 12 2025, 11:15 PM
christos removed a child revision: D48421: sound: Turn clamp macros into a function.
Closed by commit rG712f81feea41: include: add a userland version of __assert_unreachable (authored by kevans). · Explain WhyJan 13 2025, 12:42 AM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rG712f81feea41: include: add a userland version of __assert_unreachable.
christos removed a child revision: D47932: sound: Refactor the format conversion framework.Feb 25 2025, 12:11 PM
christos added a commit: rG235fe911df59: include: add a userland version of __assert_unreachable.Mar 18 2025, 1:00 PM
collin.funk1_gmail.com added a subscriber: collin.funk1_gmail.com.Mar 28 2025, 11:31 PM

C23 added unreachable () to <stddef.h>. Wouldn't that be preferable to the leading __ for userland?

kevans added a comment.Mar 29 2025, 2:43 AM
In D48077#1129981, @collin.funk1_gmail.com wrote:

C23 added unreachable () to <stddef.h>. Wouldn't that be preferable to the leading __ for userland?

My can't assume C23 in system headers, so we'd end up shimming it out with an __unreachable in <sys/cdefs.h> anyways to make it usable

Revision Contents
Changeset List

PathSize
include/
7 lines

Diff 147953

View Options

include/assert.h

Loading...