Page MenuHomeFreeBSD
Differential D48056

pkgbase: Remove /boot/firmware from bootloader package
ClosedPublic
Actions

Authored by manu on Dec 12 2024, 4:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 18, 7:27 AM
Unknown Object (File)
Mon, Sep 14, 2:35 PM
Unknown Object (File)
Mon, Sep 14, 2:26 PM
Unknown Object (File)
Mon, Sep 14, 2:24 PM
Unknown Object (File)
Thu, Sep 10, 11:28 AM
Unknown Object (File)
Sun, Sep 6, 1:46 AM
Unknown Object (File)
Sat, Sep 5, 3:34 PM
Unknown Object (File)
Thu, Sep 3, 5:25 PM
View All Files
Subscribers
emaste
imp
jrtc27

Details

Reviewers
bapt
emaste
Group Reviewers
pkgbase
Commits
rG11f3da565519: pkgbase: Remove /boot/firmware from bootloader package
Summary

For now we don't ship anything in /boot/firmware, but some up coming commit
will ship wifi drivers in it and we want them to be in their own package.

Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 61138
Build 58022: arc lint + arc unit

Event Timeline

manu created this revision.Dec 12 2024, 4:16 PM
Herald added subscribers: jrtc27, imp. · View Herald TranscriptDec 12 2024, 4:16 PM
manu requested review of this revision.Dec 12 2024, 4:16 PM
Harbormaster completed remote builds in B61119: Diff 147870.Dec 12 2024, 4:16 PM
manu added a reviewer: pkgbase.Dec 12 2024, 4:18 PM
emaste added a subscriber: emaste.Dec 12 2024, 4:32 PM

I don't know awk well enough off hand but it would seem clearer to make the condition match /boot/ and not /boot/firmware/ rather than changing it and then changing it back.

manu added a comment.Dec 12 2024, 4:33 PM
In D48056#1095238, @emaste wrote:

I don't know awk well enough off hand but it would seem clearer to make the condition match /boot/ and not /boot/firmware/ rather than changing it and then changing it back.

Agreed, but I don't know how to do this in awk :)

jrtc27 added inline comments.Dec 12 2024, 4:44 PM
release/scripts/mtree-to-plist.awk
46–49

This should be what you want, right?

manu updated this revision to Diff 147913.Dec 13 2024, 9:20 AM

Update according to @jrtc27 suggestion.

Harbormaster completed remote builds in B61138: Diff 147913.Dec 13 2024, 9:20 AM
bapt accepted this revision.Dec 13 2024, 12:25 PM
This revision is now accepted and ready to land.Dec 13 2024, 12:25 PM
emaste accepted this revision.Dec 13 2024, 12:46 PM
manu closed this revision.Dec 16 2024, 9:50 AM

Commited as 11f3da5655194c46b4acdde586ac1b8d6a196994

emaste added a commit: rG11f3da565519: pkgbase: Remove /boot/firmware from bootloader package.Dec 16 2024, 2:45 PM

Revision Contents
Changeset List

PathSize
release/
scripts/
2 lines

Diff 147913

View Options

release/scripts/mtree-to-plist.awk

Loading...