bhnd bcma/siba: Remove duplicate call to device_delete_children
ClosedPublic
Actions

Authored by jhb on Dec 6 2024, 10:31 PM.

Tags

None

Referenced Files

	F143806737: D47968.id147646.diff
	Sat, Jan 31, 2:36 PM

	Unknown Object (File)
	Sun, Jan 25, 5:42 AM

	Unknown Object (File)
	Sun, Jan 18, 9:11 AM

	Unknown Object (File)
	Sat, Jan 17, 10:12 AM

	Unknown Object (File)
	Fri, Jan 16, 8:52 PM

	Unknown Object (File)
	Tue, Jan 13, 2:59 PM

	Unknown Object (File)
	Jan 1 2026, 6:59 AM

	Unknown Object (File)
	Dec 18 2025, 10:23 PM

View All 52 Files

Subscribers

None

Details

Reviewers

imp

Commits

rG20f932af2973: bhnd bcma/siba: Remove duplicate call to device_delete_children

Summary

bcma/siba_add_children already call device_delete_children if an error
occurs.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61009
Build 57893: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Dec 6 2024, 10:31 PM

jhb created this revision.

jhb added a parent revision: D47967: siba: Use device_delete_children in siba_add_children.

Harbormaster completed remote builds in B61009: Diff 147646.Dec 6 2024, 10:31 PM

jhb added a child revision: D47969: Use bus_generic_detach instead of device_delete_children in detach.Dec 6 2024, 10:31 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 2 2025, 6:29 PM

Closed by commit rG20f932af2973: bhnd bcma/siba: Remove duplicate call to device_delete_children (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG20f932af2973: bhnd bcma/siba: Remove duplicate call to device_delete_children.

Revision Contents
Changeset List

Path

Size

sys/

dev/

bhnd/

bcma/

bcma.c

1 line

siba/

siba.c

1 line

Diff 147646

View Options

sys/dev/bhnd/bcma/bcma.c