Paths

Table of Contentst

Differential D47930

contrib/libxo: fix API header files inclusions in C++ source files
ClosedPublic
Actions

Authored by khng on Dec 5 2024, 2:09 PM.

Tags

None

Referenced Files

	F133033126: D47930.id161311.diff
	Wed, Oct 22, 6:49 AM

	Unknown Object (File)
	Sun, Oct 19, 12:02 AM

	Unknown Object (File)
	Wed, Oct 15, 2:41 AM

	Unknown Object (File)
	Wed, Oct 8, 8:31 AM

	Unknown Object (File)
	Fri, Oct 3, 2:33 PM

	Unknown Object (File)
	Wed, Oct 1, 11:02 AM

	Unknown Object (File)
	Wed, Oct 1, 3:13 AM

	Unknown Object (File)
	Wed, Oct 1, 2:01 AM

View All 53 Files

Subscribers

Details

Reviewers

lwhsu
phil
imp
aokblast

Commits

rGc065db9f83ff: contrib/libxo: fix API header files inclusions in C++ source files
rG6faaef201ca3: contrib/libxo: fix API header files inclusions in C++ source files
rG11ace56fa030: contrib/libxo: fix API header files inclusions in C++ source files

Summary

C++ source files need extern "C" to disable C++ name mangling.

Diff Detail

Repository

rG FreeBSD src repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 60967
Build 57851: arc lint + arc unit

Event Timeline

aokblast created this revision.Dec 5 2024, 2:09 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 5 2024, 2:09 PM

aokblast requested review of this revision.Dec 5 2024, 2:09 PM

Harbormaster completed remote builds in B60967: Diff 147529.Dec 5 2024, 2:09 PM

aokblast added reviewers: lwhsu, phil.Dec 5 2024, 2:11 PM

@phil for a confirmation as well.

This revision is now accepted and ready to land.Dec 5 2024, 9:56 PM

Patch looks fine. I'll add to the main libxo repo.

Thanks,
Phil

In D47930#1093223, @phil wrote:

Patch looks fine. I'll add to the main libxo repo.

Thanks,
Phil

FYI @aokblast also submitted as https://github.com/Juniper/libxo/pull/100

Update with github version

This revision now requires review to proceed.Jan 16 2025, 6:09 PM

Harbormaster completed remote builds in B61775: Diff 149398.Jan 16 2025, 6:10 PM

Looks good, not surprised upstream accepted it :).

This revision is now accepted and ready to land.Jan 16 2025, 6:25 PM

khng commandeered this revision.Aug 23 2025, 9:02 AM

khng edited reviewers, added: aokblast; removed: khng.

aokblast accepted this revision.Aug 23 2025, 9:09 AM

Why do you need this on xo_buf.h, an internal file?

In the FWIW department: It always seems odd that C++ needs decoration in non-C++ files, rather that have this knowledge in compiler command line arguments (e.g. "--c-include /usr/include").

Thanks,
Phil

This revision now requires changes to proceed.Aug 25 2025, 5:10 PM

In D47930#1191301, @phil wrote:

Why do you need this on xo_buf.h, an internal file?

In the FWIW department: It always seems odd that C++ needs decoration in non-C++ files, rather that have this knowledge in compiler command line arguments (e.g. "--c-include /usr/include").

Thanks,
Phil

Oops sorry. @khng tells me that he will figure it out before merging it.

khng retitled this revision from contrib/libxo/libxo/*.h fix libxo header include when the source is C++ to contrib/libxo: fix API header files inclusions in C++ source files.Sep 1 2025, 2:47 AM

khng edited the summary of this revision. (Show Details)

Updated.

Harbormaster completed remote builds in B66732: Diff 161311.Sep 1 2025, 2:47 AM

Looks good. Thanks..

This revision is now accepted and ready to land.Sep 2 2025, 1:36 PM

Closed by commit rG11ace56fa030: contrib/libxo: fix API header files inclusions in C++ source files (authored by aokblast, committed by khng). · Explain WhySep 7 2025, 6:42 PM

This revision was automatically updated to reflect the committed changes.

khng added a commit: rG11ace56fa030: contrib/libxo: fix API header files inclusions in C++ source files.

khng added a commit: rG6faaef201ca3: contrib/libxo: fix API header files inclusions in C++ source files.Sep 14 2025, 12:31 AM

khng added a commit: rGc065db9f83ff: contrib/libxo: fix API header files inclusions in C++ source files.Sep 14 2025, 12:34 AM

Revision Contents
Changeset List

Path

Size

contrib/

libxo/

libxo/

8 lines

8 lines

8 lines

7 lines

Diff 147529

contrib/libxo/libxo/xo.h

Loading...

contrib/libxo/libxo/xo_buf.h

Loading...

contrib/libxo/libxo/xo_encoder.h

Loading...

contrib/libxo/libxo/xo_explicit.h

Loading...