libc: stop exporting cerror
ClosedPublic
Actions

Authored by emaste on Mar 29 2016, 5:36 PM.

Details

Reviewers

brooks
jhibbits
jilles
imp

Commits

rS297418: libc: stop exporting cerror

Summary

i386 stopped exporting .cerror in rS240152, and likewise for amd64 in rS240178. It is not used by other libraries on any platform, so apply the same change to the remaining instances.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 14718.Mar 29 2016, 5:36 PM

emaste retitled this revision from to libc: stop exporting cerror.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: imp, brooks, jhibbits.

emaste added a subscriber: jilles.Mar 29 2016, 5:38 PM

emaste added inline comments.

lib/libc/arm/Symbol.map
32	Not sure how this ended up exported in `FBSD_1.0` but it's an error anyway
lib/libc/mips/Symbol.map
31	Not sure how this ended up exported in `FBSD_1.0` but it's an error anyway

jhibbits accepted this revision.Mar 29 2016, 5:42 PM

jhibbits edited edge metadata.

This revision is now accepted and ready to land.Mar 29 2016, 5:42 PM

Looks good to me (but probably avoid MFC).

As a followup, architecture maintainers could take advantage of this to use simpler code sequences to access .cerror (and curbrk and minbrk), like rS240152 for i386 and rS240178 for amd64.

In D5774#123387, @jilles wrote:

Looks good to me (but probably avoid MFC).

As a followup, architecture maintainers could take advantage of this to use simpler code sequences to access .cerror (and curbrk and minbrk), like rS240152 for i386 and rS240178 for amd64.