HomeFreeBSD

libc/amd64: Do not export .cerror.
rS240178Unpublished

Unpublished Commit ยท Learn More

No further details are available.

Description

libc/amd64: Do not export .cerror.

For some reason, libc exports the symbol .cerror (HIDENAME(cerror)), albeit
in the FBSDprivate_1.0 version. It looks like there is no reason for this
since it is not used from other libraries. Given that it cannot be accessed
from C and its strange calling convention, it is rather unlikely that other
things rely on it. Perhaps it is from a time when symbols could not be
hidden.

Most of the amd64 assembler code jumps to .cerror using the GOT. It can jump
to it directly now, as in non-PIC mode.

There are also some minor size optimizations to instructions but they yield
virtually no benefit in the size of libc.so.7 due to padding.

Reviewed by: kib

Details

Provenance
jillesAuthored on
Parents
rS240177: Dynamically allocate the S/G lists passed to callback routines rather than
Branches
Unknown
Tags
Unknown