locks: Use %p to print uintptr_t values
ClosedPublic
Actions

Authored by jhb on Oct 30 2024, 6:23 PM.

Tags

None

Referenced Files

	F115640932: D47342.diff
	Sat, Apr 26, 10:26 AM

	Unknown Object (File)
	Wed, Apr 23, 5:30 AM

	Unknown Object (File)
	Wed, Apr 23, 4:02 AM

	Unknown Object (File)
	Wed, Apr 23, 12:57 AM

	Unknown Object (File)
	Wed, Apr 23, 12:57 AM

	Unknown Object (File)
	Wed, Apr 23, 12:36 AM

	Unknown Object (File)
	Wed, Apr 23, 12:03 AM

	Unknown Object (File)
	Thu, Apr 17, 2:47 AM

View All 36 Files

Subscribers

imp

olce

Details

Reviewers

mjg
jrtc27

Commits

rG73da0265c29c: locks: Use %p to print uintptr_t values

Summary

Pointers are not the same shape as sizes on CHERI architectures. Cast
to void * and print with %p instead.

Obtained from: CheriBSD

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Oct 30 2024, 6:23 PM

Herald added subscribers: olce, imp. · View Herald TranscriptOct 30 2024, 6:23 PM

jhb requested review of this revision.Oct 30 2024, 6:23 PM

Harbormaster completed remote builds in B60266: Diff 145685.Oct 30 2024, 6:23 PM

(Alternatively, one could use the ugly PRIxPTR macro in place of the zx)

This revision was not accepted when it landed; it landed in state Needs Review.Nov 14 2024, 2:59 PM

Closed by commit rG73da0265c29c: locks: Use %p to print uintptr_t values (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG73da0265c29c: locks: Use %p to print uintptr_t values.

glebius added a reverting change: rG83d13d836b32: locks: run the extra NULL check only with INVARIANTS.Sun, Mar 30, 4:01 AM

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_mutex.c

2 lines

kern_rwlock.c

8 lines

Diff 146445

View Options

sys/kern/kern_mutex.c