Fix up headers which previously assumed that refcount.h includes
systm.h, and make them more self-contained. Then, replace the systm.h
include in refcount with kassert.h.
MFC after: 1 week
Details
Details
- Reviewers
kib imp - Commits
- rGd14c38ceb8aa: sys: Avoid relying on pollution from refcount.h
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 60400 Build 57284: arc lint + arc unit
Event Timeline
Comment Actions
We have tests to make sure that some (most) of the sys/*.h files are self-contained.
Can we remove anything from the 'known bad' lists after this?
| sys/sys/refcount.h | ||
|---|---|---|
| 48 | u_int comes from machine/atomic.h->sys/atomic_common.h->sys/types.h. | |
| sys/sys/refcount.h | ||
|---|---|---|
| 48 | I'd rather replace u_int with unsigned int, but it's a lot of churn. | |
| sys/sys/refcount.h | ||
|---|---|---|
| 48 | That might be only marginally better. You'd avoid the namespace pollution of types.h, since u_int isn't defined in _types.h.. But it would be a lot more churn... | |