Page MenuHomeFreeBSD
Differential D47342

locks: Use %p to print uintptr_t values
ClosedPublic
Actions

Authored by jhb on Oct 30 2024, 6:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 5:42 PM
Unknown Object (File)
Mar 8 2025, 9:49 PM
Unknown Object (File)
Mar 8 2025, 3:02 AM
Unknown Object (File)
Mar 4 2025, 8:25 AM
Unknown Object (File)
Feb 28 2025, 8:49 AM
Unknown Object (File)
Feb 27 2025, 8:22 PM
Unknown Object (File)
Feb 15 2025, 8:34 AM
Unknown Object (File)
Feb 10 2025, 11:38 PM
View All 27 Files
Subscribers
imp
olce

Details

Reviewers
mjg
jrtc27
Commits
rG73da0265c29c: locks: Use %p to print uintptr_t values
Summary

Pointers are not the same shape as sizes on CHERI architectures. Cast
to void * and print with %p instead.

Obtained from: CheriBSD

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60266
Build 57150: arc lint + arc unit

Event Timeline

jhb created this revision.Oct 30 2024, 6:23 PM
Herald added subscribers: olce, imp. · View Herald TranscriptOct 30 2024, 6:23 PM
jhb requested review of this revision.Oct 30 2024, 6:23 PM
Harbormaster completed remote builds in B60266: Diff 145685.Oct 30 2024, 6:23 PM
jrtc27 added a comment.Oct 30 2024, 6:25 PM

(Alternatively, one could use the ugly PRIxPTR macro in place of the zx)

This revision was not accepted when it landed; it landed in state Needs Review.Nov 14 2024, 2:59 PM
Closed by commit rG73da0265c29c: locks: Use %p to print uintptr_t values (authored by jhb). · Explain Why
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG73da0265c29c: locks: Use %p to print uintptr_t values.
glebius added a reverting change: rG83d13d836b32: locks: run the extra NULL check only with INVARIANTS.Sun, Mar 30, 4:01 AM

Revision Contents
Changeset List

PathSize
sys/
kern/
2 lines
8 lines

Diff 145685

View Options

sys/kern/kern_mutex.c

Loading...
View Options

sys/kern/kern_rwlock.c

Loading...