Page MenuHomeFreeBSD
Differential D5714

hyperv/utils: Allow hint to disable individual utility
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Mar 23 2016, 2:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 23, 4:39 AM
Unknown Object (File)
Sat, Oct 18, 6:23 PM
Unknown Object (File)
Thu, Oct 16, 6:52 PM
Unknown Object (File)
Fri, Oct 10, 11:27 PM
Unknown Object (File)
Fri, Oct 10, 11:27 PM
Unknown Object (File)
Fri, Oct 10, 11:27 PM
Unknown Object (File)
Fri, Oct 10, 5:08 PM
Unknown Object (File)
Sat, Oct 4, 4:32 PM
View All Files
Subscribers
None

Details

Reviewers
kib
howard0su_gmail.com
honzhan_microsoft.com
decui_microsoft.com
delphij
royger
adrian
Commits
rS297220: hyperv/utils: Allow hint to disable individual utility

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sepherosa_gmail.com updated this revision to Diff 14536.Mar 23 2016, 2:12 AM
sepherosa_gmail.com retitled this revision from to hyperv/utils: Allow hint to disable individual utility.
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
sepherosa_gmail.com added reviewers: adrian, delphij, royger, kib, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.
decui_microsoft.com accepted this revision.Mar 23 2016, 2:56 AM
decui_microsoft.com edited edge metadata.

LGTM

This revision is now accepted and ready to land.Mar 23 2016, 2:56 AM
kib added inline comments.Mar 23 2016, 10:19 AM
sys/dev/hyperv/utilities/hv_heartbeat.c
98 ↗(On Diff #14536)

Might be, use more structural names, like hyperv.heartbeat etc ?

99 ↗(On Diff #14536)

Note that style requires braces () around the return value.

sepherosa_gmail.com added inline comments.Mar 24 2016, 12:45 AM
sys/dev/hyperv/utilities/hv_heartbeat.c
98 ↗(On Diff #14536)

Not 100% sure about the practice, but looks like most users of resource_disabled() just use the driver's name

99 ↗(On Diff #14536)

Hmm, this tries to make the style consistent within this function :)

Closed by commit rS297220: hyperv/utils: Allow hint to disable individual utility (authored by sephe). · Explain WhyMar 24 2016, 1:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
hyperv/
utilities/
4 lines
4 lines
4 lines
4 lines

Diff 14564

View Options

head/sys/dev/hyperv/utilities/hv_heartbeat.c

Loading...
View Options

head/sys/dev/hyperv/utilities/hv_kvp.c

Loading...
View Options

head/sys/dev/hyperv/utilities/hv_shutdown.c

Loading...
View Options

head/sys/dev/hyperv/utilities/hv_timesync.c

Loading...