sound: Move sndstat_register() call to pcm_setstatus()
ClosedPublic
Actions

Authored by christos on Oct 28 2024, 10:30 PM.

Details

Reviewers

markj
emaste
dev_submerge.ch

Commits

rG9e36026dc3ea: sound: Move sndstat_register() call to pcm_setstatus()
rG181a31d83490: sound: Move sndstat_register() call to pcm_setstatus()

Summary

The d->status string is populated in pcm_setstatus() anyway, so call
sndstat_register() after we populate it, and are closer to finalizing
the device creation.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60232
Build 57116: arc lint + arc unit

Event Timeline

christos created this revision.Oct 28 2024, 10:30 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 28 2024, 10:30 PM

christos requested review of this revision.Oct 28 2024, 10:30 PM

Harbormaster completed remote builds in B60232: Diff 145568.Oct 28 2024, 10:30 PM

christos added a parent revision: D47322: sound: Move sysctl and /dev/dspX creation to pcm_setstatus().Oct 28 2024, 10:30 PM

christos added a child revision: D47324: sound: Remove early SD_F_SIMPLEX and SD_F_AUTOVCHAN assignments.

dev_submerge.ch accepted this revision.Oct 30 2024, 9:39 AM

This revision is now accepted and ready to land.Oct 30 2024, 9:39 AM

markj accepted this revision.Oct 30 2024, 12:59 PM

Closed by commit rG181a31d83490: sound: Move sndstat_register() call to pcm_setstatus() (authored by christos). · Explain WhyNov 3 2024, 7:05 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG181a31d83490: sound: Move sndstat_register() call to pcm_setstatus().

christos added a commit: rG9e36026dc3ea: sound: Move sndstat_register() call to pcm_setstatus().Nov 5 2024, 9:45 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

sound.c

3 lines

Diff 145568

View Options

sound: Move sndstat_register() call to pcm_setstatus()ClosedPublicActions