Page MenuHomeFreeBSD
Differential D47273

git-arc: Quote echoed variables
AbandonedPublic
Actions

Authored by 0mp on Oct 24 2024, 8:42 AM.
Tags
None
Referenced Files
F105544898: D47273.diff
Tue, Dec 17, 11:50 AM
Unknown Object (File)
Fri, Nov 29, 9:43 PM
Unknown Object (File)
Fri, Nov 29, 6:52 PM
Unknown Object (File)
Oct 30 2024, 3:49 AM
Unknown Object (File)
Oct 28 2024, 10:32 AM
Unknown Object (File)
Oct 28 2024, 1:23 AM
Subscribers
imp
jlduran

Details

Reviewers
bnovkov
christos
markj
Summary

This is a preparation for an eventual transition to printfs. Let's make
sure that we do not depend on globbing and word splitting.

MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60180
Build 57064: arc lint + arc unit

Event Timeline

0mp created this revision.Oct 24 2024, 8:42 AM
Herald added a subscriber: imp. · View Herald TranscriptOct 24 2024, 8:42 AM
0mp requested review of this revision.Oct 24 2024, 8:42 AM
Harbormaster completed remote builds in B60180: Diff 145415.Oct 24 2024, 8:42 AM
0mp added a child revision: D47274: git-arc: Use printf instead of echo.Oct 24 2024, 8:43 AM
0mp added reviewers: bnovkov, christos, markj.
christos accepted this revision.Oct 24 2024, 10:40 AM
This revision is now accepted and ready to land.Oct 24 2024, 10:40 AM
markj added a comment.Oct 24 2024, 2:38 PM

Seems fine, but it's gratuitous in my opinion. This could be done at the same time as converting to printf.

0mp abandoned this revision.Oct 25 2024, 1:29 PM
0mp added a subscriber: jlduran.

Considering that git-arc is now more portable thanks to the patches by @jlduran_gmail.com, I'm closing this revision. If we decide to start quoting variables in git-arc for the sake of defensive programming, we should review the whole file instead of just the echo cases.

Revision Contents
Changeset List

PathSize
tools/
tools/
git/
8 lines

Diff 145415

View Options

tools/tools/git/git-arc.sh

Loading...