git-arc: Quote echoed variables
AbandonedPublic
Actions

Authored by 0mp on Oct 24 2024, 8:42 AM.

Tags

None

Referenced Files

	F109062550: D47273.id.diff
	Fri, Jan 31, 7:38 AM

	Unknown Object (File)
	Sun, Jan 26, 6:13 PM

	Unknown Object (File)
	Wed, Jan 22, 2:58 AM

	Unknown Object (File)
	Wed, Jan 22, 1:33 AM

	Unknown Object (File)
	Wed, Jan 22, 12:22 AM

	Unknown Object (File)
	Wed, Jan 15, 4:01 PM

	Unknown Object (File)
	Dec 17 2024, 8:56 PM

	Unknown Object (File)
	Dec 17 2024, 11:50 AM

View All 13 Files

Subscribers

imp

jlduran

Details

Reviewers

bnovkov
christos
markj

Summary

This is a preparation for an eventual transition to printfs. Let's make
sure that we do not depend on globbing and word splitting.

MFC after: 2 weeks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60180
Build 57064: arc lint + arc unit

Event Timeline

0mp created this revision.Oct 24 2024, 8:42 AM

Herald added a subscriber: imp. · View Herald TranscriptOct 24 2024, 8:42 AM

0mp requested review of this revision.Oct 24 2024, 8:42 AM

Harbormaster completed remote builds in B60180: Diff 145415.Oct 24 2024, 8:42 AM

0mp added a child revision: D47274: git-arc: Use printf instead of echo.Oct 24 2024, 8:43 AM

0mp added reviewers: bnovkov, christos, markj.

christos accepted this revision.Oct 24 2024, 10:40 AM

This revision is now accepted and ready to land.Oct 24 2024, 10:40 AM

Seems fine, but it's gratuitous in my opinion. This could be done at the same time as converting to printf.

Considering that git-arc is now more portable thanks to the patches by @jlduran_gmail.com, I'm closing this revision. If we decide to start quoting variables in git-arc for the sake of defensive programming, we should review the whole file instead of just the echo cases.

Revision Contents
Changeset List

Path

Size

tools/

git/

git-arc.sh

8 lines

Diff 145415

View Options

tools/tools/git/git-arc.sh

git-arc: Quote echoed variablesAbandonedPublicActions