onyx: Remove unreachable if condition
ClosedPublic
Actions

Authored by christos on Oct 17 2024, 2:41 PM.

Details

Reviewers

markj
emaste
andreast

Commits

rGe609dfa98fd3: onyx: Remove unreachable if condition
rG6f96ef84b359: onyx: Remove unreachable if condition

Summary

Both conditions are the same, so the second one is unreachable.

PR: 229550
Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Oct 17 2024, 2:41 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 17 2024, 2:41 PM

christos requested review of this revision.Oct 17 2024, 2:41 PM

Harbormaster completed remote builds in B60059: Diff 145042.Oct 17 2024, 2:41 PM

I think this was probably the intent, yes.

This revision is now accepted and ready to land.Oct 17 2024, 3:11 PM

emaste added a reviewer: andreast.Oct 17 2024, 3:31 PM

Seems like a strange error to make and this is a functional change because the code in the else if block is dead today. I added @andreast as the committer of 9c3fbfbd6a739b053611d35ead0a67a5ecba8825 but I wouldn't be surprised if this hardware is not functional any longer.

I don't object to landing this though - if someone reports that the driver no longer probes we can get them to investigate.

Fine with me. I'm pretty sure, no machine with this chip will run an actual FreeBSD. Speaking for me, I have given up Mac PowerPC and FreeBSD a long time ago.

Closed by commit rG6f96ef84b359: onyx: Remove unreachable if condition (authored by christos). · Explain WhyOct 18 2024, 8:51 AM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG6f96ef84b359: onyx: Remove unreachable if condition.

christos added a commit: rGe609dfa98fd3: onyx: Remove unreachable if condition.Oct 20 2024, 11:22 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

macio/

onyx.c

1 line

Diff 145100

View Options

sys/dev/sound/macio/onyx.c

Context not available.
	* Dependency Conflicts: If multiple thin jails require different versions of the same libraries or software, managing dependencies can become complex. In some cases, this might require additional effort to ensure compatibility.	* Dependency Conflicts: If multiple thin jails require different versions of the same libraries or software, managing dependencies can become complex. In some cases, this might require additional effort to ensure compatibility.
	* Compatibility Challenges: Applications within a thin jail might encounter compatibility issues if they assume a certain base system environment that differs from the shared components provided by the template.	* Compatibility Challenges: Applications within a thin jail might encounter compatibility issues if they assume a certain base system environment that differs from the shared components provided by the template.

		[[service-jails]]
		=== Service Jails

		A service jail shares the complete filesystem tree directly with the host (the jail root path is [.filename]#/#) and as such can access and modify any file on the host, and shares the same user accounts with the host.
		bcrUnsubmitted Done Inline Actions s/Service/service/g bcr: s/Service/service/g
		netchildAuthorUnsubmitted Done Inline Actions I tried to match the style of the existing Thick Jails and Thin Jails above this new part. I may have not understood when to use the uppercase "Thick jail" vs. the "thick jail" part... Can you give me a hint before I blindly lowercase "Service" in the middle of a sentence? netchild: I tried to match the style of the existing Thick Jails and Thin Jails above this new part. I…
		By default it has no access to the network or other resources which are restricted in jails, but they can be configured to re-use the network of the host and to remove some of the jail-restrictions.
		The use case for service jails is automatic confinement of services/daemons inside a jail with minimal configuration, and without any knowledge of the files needed by such service/daemon.
		fernapeUnsubmitted Done Inline Actions Something to change the use of `jailing` as a verb (which is repetitive with regards to `service jail`): The use case for service jails is automatic jailing... --> The use case for service jails is automatic confinement of services/daemons inside a jail... The last part does not read very clear to me: `with the least amount of configuration` refers to the jail, but in the middle there is information about needed files... How about: `The use case for service jails is automatic confinement of services/daemons inside a jail with minimal configuration, and without any knowledge of the files needed by such service/daemon`. fernape: Something to change the use of `jailing` as a verb (which is repetitive with regards to…
		Service jails exist since FreeBSD 15.

		Advantages of Service Jails:
		bcrUnsubmitted Done Inline Actions Is this a section heading? bcr: Is this a section heading?
		netchildAuthorUnsubmitted Done Inline Actions No. It is a list like for Thick Jails and Thin Jails in the existing text above. netchild: No. It is a list like for Thick Jails and Thin Jails in the existing text above.

		fernapeUnsubmitted Done Inline Actions This list does not render properly. A blank line between the above line an the first bullet is needed (I did not test it). You can run `make run` and visit the local doc set to do some proofreading. fernape: This list does not render properly. A blank line between the above line an the first bullet is…
		netchildAuthorUnsubmitted Done Inline Actions I more or less copy&pasted what was above. There are no blank lines either. Do you have a reference to which ports/packages I need to install to be able to "make run". netchild: I more or less copy&pasted what was above. There are no blank lines either. Do you have a…
		fernapeUnsubmitted Done Inline Actions Just `hugo`. fernape: Just `hugo`.
		* Zero Administration: A service jail ready service needs only one config line in [.filename]#/etc/rc.conf#, a service which is not service jails ready needs two config lines.
		fernapeUnsubmitted Done Inline Actions Service --> service and then Thin --> thin for consistency. fernape: //Service// --> //service// and then //Thin// --> //thin// for consistency.
		netchildAuthorUnsubmitted Done Inline Actions Done... but all the existing parts around it use uppercase versions of Thick/Thin... netchild: Done... but all the existing parts around it use uppercase versions of Thick/Thin...
		* Resource Efficiency: Service jails are more resource efficient than thin jails, as they do not need any additional disk space or network resource.
		* Faster Deployment: Creating and launching service jails is generally faster compared to thin jails if only distinct services/daemons shall be jailed and no parallel instances of the same service/daemon is needed.
		* Shared Resources: Service jails share all resources such as libraries and binaries with the host system. This can potentially lead to more efficient disk caching and improved performance for applications within the jail.
		* Process Isolation: Service jails isolate a particular service, it can not see processes which are not a child of the service jail, even if they run within the same user account.

		Disadvantages of Service Jails:

		* Reduced Isolation: The primary disadvantage of service jails is that they offer no filesystem isolation compared to thick or thin jails.
		* Security Concerns: The reduced isolation in service jails could pose security risks, as a compromise in one jail might have a greater potential to affect everything on the host system.

		Most of the configuration of jails which is discussed below is not needed for service jails.
		To understand how jails work, it is recommended to understand those configuration possibilities. The details about what is needed to configure a service jail is in crossref:jails[service-jails-config, Configuring service jails].

	[[vnet-jails]]	[[vnet-jails]]
	=== VNET Jails	=== VNET Jails

Context not available.

	More information can be found in the chapter crossref:linuxemu[linuxemu,Linux Binary Compatibility].	More information can be found in the chapter crossref:linuxemu[linuxemu,Linux Binary Compatibility].

		[[service-jails-config]]
		pauamma_gundo.comUnsubmitted Done Inline Actions s/basesystem/base system/ here too. pauamma_gundo.com: s/basesystem/base system/ here too.
		=== Configuring Service Jails

		bcrUnsubmitted Done Inline Actions s/Basesystem/Base system/ bcr: s/Basesystem/Base system/
		fernapeUnsubmitted Done Inline Actions Very long line with many examples in the middle of the sentence. How about: `Base system services which do not make sense to run inside jails are configured to not be started as a service jail, even if enabled in [.filename]#/etc/rc.conf#.` `Some examples of such a service are servicew which want to mount or unmount something in the start of stop method, or only configure something like a route, or firewall, or the like.` Also typo someting/ --> something// fernape: Very long line with many examples in the middle of the sentence. How about: `Base system…
		A service jail is configured completely via [.filename]#/etc/rc.conf# or man:sysrc[8].
		The base system services are service jails ready.
		fernapeUnsubmitted Done Inline Actions 3rd --> Third fernape: //3rd// --> //Third//
		They contain a config line which enables networking or lift other restrictions of jails.
		Base system services which do not make sense to run inside jails are configured to not be started as a service jail, even if enabled in [.filename]#/etc/rc.conf#.
		Some examples of such a service are services which want to mount or unmount something in the start of stop method, or only configure something like a route, or firewall, or the like.

		Third party services may or may not be service jails ready. To check if a service is service jail ready, the following command can be used:

		[source,shell]
		....
		# grep _svcj_options /path/to/rc.d/servicename
		fernapeUnsubmitted Done Inline Actions Typo neccessary --> necessary fernape: Typo //neccessary// --> //necessary//
		....

		If there is no output, the service is not service jail ready, or does not need any additional privileges like e.g. network access.

		If the service is not service jail ready, and needs network access, it can be made ready by adding the necessary config to [.filename]#/etc/rc.conf#:

		[source,shell]
		fernapeUnsubmitted Done Inline Actions _svcj_options --> `_svcj_options` (to signal this is "code" text and not "normal" text). fernape: //_svcj_options// --> //`_svcj_options`// (to signal this is "code" text and not "normal" text).
		....
		# sysrc servicename_svcj_options=net_basic
		....
		bcrUnsubmitted Done Inline Actions s/So// s/can be used/Use the following sequence/ (active voice) bcr: s/So// s/can be used/Use the following sequence/ (active voice)

		For all possible `_svcj_options` see the man:rc.conf[5] man-page.

		To enable a service jail for a given service, the service needs to be stopped and the `servicename_svcj` variable needs to be set to YES.
		To put man:syslogd[8] into a service jail, use the following sequence of commands:

		[source,shell]
		....
		# service syslogd stop
		fernapeUnsubmitted Done Inline Actions Try to avoid the use of `you`. Use the passive voice here. fernape: Try to avoid the use of `you`. Use the passive voice here.
		# sysrc syslogd_svcj=YES
		# service syslogd start
		....

		fernapeUnsubmitted Done Inline Actions This crossref points to http://localhost:1313/en/books/handbook/jail/#jail-management while it should point to http://localhost:1313/en/books/handbook/jails/#jail-management (note the `jail` --> `jails` in the URL). These are easily caught with `make run` :-) fernape: This crossref points to http://localhost:1313/en/books/handbook/jail/#jail-management while it…
		If the `servicename_svcj` variable is changed, the service needs to be stopped before it is changed.
		If it is not stopped, the rc framework will not detect the correct state of the service and will not be able to do what is requested.

		Service jails are managed only via man:rc.conf[5]/man:sysrc[8] and the man:service[8] command.
		The jail utilities, like man:jls[8] as described in crossref:jails[jail-management,Jail Management] can be used to investigate the operation, but the man:jail[8] command is not supposed to be used to manage them.

	[[jail-management]]	[[jail-management]]
	== Jail Management	== Jail Management

Context not available.

onyx: Remove unreachable if conditionClosedPublicActions