Page MenuHomeFreeBSD
Differential D47103

dpaa2: allow tapping of tx packet in dpni
ClosedPublic
Actions

Authored by bz on Oct 13 2024, 11:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 11, 4:44 AM
Unknown Object (File)
Tue, Sep 8, 4:19 AM
Unknown Object (File)
Fri, Sep 4, 11:49 PM
Unknown Object (File)
Fri, Sep 4, 7:36 PM
Unknown Object (File)
Fri, Sep 4, 7:35 PM
Unknown Object (File)
Fri, Sep 4, 11:58 AM
Unknown Object (File)
Thu, Sep 3, 6:04 PM
Unknown Object (File)
Thu, Sep 3, 8:40 AM
View All Files
Subscribers
dch
imp
matt_traverse.com.au

Details

Reviewers
dsl
Commits
rG9e596eab21d4: dpaa2: allow tapping of tx packets in dpni
rGe69e172d4058: dpaa2: allow tapping of tx packets in dpni
Summary

Packet capturing on dpni is only half-working given the BPF_MTAP call
in the TX is missing. Add it to see packets in both directions.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 59965
Build 56850: arc lint + arc unit

Event Timeline

bz created this revision.Oct 13 2024, 11:18 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 13 2024, 11:18 PM
bz requested review of this revision.Oct 13 2024, 11:18 PM
Harbormaster completed remote builds in B59965: Diff 144795.Oct 13 2024, 11:18 PM
dsl accepted this revision.Oct 14 2024, 10:57 AM

LGTM, but why "half-working"? Is there BFP_MTAP on Rx somewhere?

This revision is now accepted and ready to land.Oct 14 2024, 10:57 AM
bz added a comment.Oct 14 2024, 5:43 PM
In D47103#1073636, @dsl wrote:

LGTM, but why "half-working"? Is there BFP_MTAP on Rx somewhere?

ether_input_internal()

Closed by commit rGe69e172d4058: dpaa2: allow tapping of tx packets in dpni (authored by bz). · Explain WhyOct 14 2024, 5:44 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rGe69e172d4058: dpaa2: allow tapping of tx packets in dpni.
bz added a commit: rG9e596eab21d4: dpaa2: allow tapping of tx packets in dpni.Oct 17 2024, 9:18 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
dpaa2/
2 lines

Diff 144795

View Options

sys/dev/dpaa2/dpaa2_ni.c

Loading...