dpaa2: allow tapping of tx packet in dpni
ClosedPublic
Actions

Authored by bz on Oct 13 2024, 11:18 PM.

Tags

None

Referenced Files

	F107390612: D47103.id144795.diff
	Mon, Jan 13, 11:54 AM

	F107390609: D47103.id144795.diff
	Mon, Jan 13, 11:54 AM

	F107390605: D47103.id144795.diff
	Mon, Jan 13, 11:54 AM

	Unknown Object (File)
	Fri, Jan 10, 5:40 AM

	Unknown Object (File)
	Dec 12 2024, 7:36 PM

	Unknown Object (File)
	Nov 29 2024, 10:20 AM

	Unknown Object (File)
	Nov 26 2024, 12:59 AM

	Unknown Object (File)
	Nov 25 2024, 3:04 PM

Subscribers

Details

Reviewers

dsl

Commits

rG9e596eab21d4: dpaa2: allow tapping of tx packets in dpni
rGe69e172d4058: dpaa2: allow tapping of tx packets in dpni

Summary

Packet capturing on dpni is only half-working given the BPF_MTAP call
in the TX is missing. Add it to see packets in both directions.

MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 59965
Build 56850: arc lint + arc unit

Event Timeline

bz created this revision.Oct 13 2024, 11:18 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 13 2024, 11:18 PM

bz requested review of this revision.Oct 13 2024, 11:18 PM

Harbormaster completed remote builds in B59965: Diff 144795.Oct 13 2024, 11:18 PM

LGTM, but why "half-working"? Is there BFP_MTAP on Rx somewhere?

This revision is now accepted and ready to land.Oct 14 2024, 10:57 AM

In D47103#1073636, @dsl wrote:

LGTM, but why "half-working"? Is there BFP_MTAP on Rx somewhere?

ether_input_internal()

Closed by commit rGe69e172d4058: dpaa2: allow tapping of tx packets in dpni (authored by bz). · Explain WhyOct 14 2024, 5:44 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rGe69e172d4058: dpaa2: allow tapping of tx packets in dpni.

bz added a commit: rG9e596eab21d4: dpaa2: allow tapping of tx packets in dpni.Oct 17 2024, 9:18 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

dpaa2/

dpaa2_ni.c

2 lines

Diff 144795

View Options

dpaa2: allow tapping of tx packet in dpniClosedPublicActions