Differential D46922

cred: proc_set_cred(): Remove obsolete comments
ClosedPublic
Actions

Authored by olce on Oct 4 2024, 8:12 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Sep 6, 7:43 PM

	Unknown Object (File)
	Sun, Sep 6, 4:37 PM

	Unknown Object (File)
	Fri, Sep 4, 10:46 PM

	Unknown Object (File)
	Fri, Sep 4, 10:22 PM

	Unknown Object (File)
	Tue, Sep 1, 8:08 PM

	Unknown Object (File)
	Fri, Aug 28, 1:37 PM

	Unknown Object (File)
	Tue, Aug 11, 1:25 PM

	Unknown Object (File)
	Tue, Aug 11, 4:18 AM

Subscribers

Details

Reviewers

mhorne
mjg
emaste

Commits

rGd1830c75865c: cred: proc_set_cred(): Remove obsolete comments
rG07c9edac7bcd: cred: proc_set_cred(): Remove obsolete comments

Summary

These have been obsoleted since they were first written (in commit
"cred: add proc_set_cred helper", daf63fd2f9a8d040, r280130) by some
subsequent commits ("proc: refactor clearing credentials into
proc_unset_cred", 5a90435ccfed8e1e, r361448 ; "cred: distribute
reference count per thread", 1724c563e62fa800, r361993).

No functional change.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59733
Build 56619: arc lint + arc unit

Event Timeline

olce created this revision.Oct 4 2024, 8:12 AM

Herald added a subscriber: imp. · View Herald TranscriptOct 4 2024, 8:12 AM

olce requested review of this revision.Oct 4 2024, 8:12 AM

Harbormaster completed remote builds in B59733: Diff 144220.Oct 4 2024, 8:12 AM

olce added a subscriber: bapt.Oct 4 2024, 8:17 AM

olce added a child revision: D46921: mountd(8): parsecred(): Groups limit: NGROUPS_MAX => NGROUPS_MAX + 1.Oct 4 2024, 8:30 AM

olce removed a child revision: D46921: mountd(8): parsecred(): Groups limit: NGROUPS_MAX => NGROUPS_MAX + 1.

olce added a child revision: D46923: cred: proc_set_cred(), proc_unset_cred(): Update user's process count.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 16 2024, 2:46 PM

Closed by commit rG07c9edac7bcd: cred: proc_set_cred(): Remove obsolete comments (authored by olce). · Explain Why

This revision was automatically updated to reflect the committed changes.

olce added a commit: rG07c9edac7bcd: cred: proc_set_cred(): Remove obsolete comments.

olce added a commit: rGd1830c75865c: cred: proc_set_cred(): Remove obsolete comments.Jan 16 2025, 6:09 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

5 lines

Diff 144220

sys/kern/kern_prot.c

Loading...