Page MenuHomeFreeBSD
Differential D46886

osd: Constify signature of osd_register()
ClosedPublic
Actions

Authored by olce on Oct 3 2024, 4:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 9, 10:40 PM
Unknown Object (File)
Tue, Mar 4, 3:05 PM
Unknown Object (File)
Thu, Feb 27, 6:12 AM
Unknown Object (File)
Wed, Feb 26, 1:15 PM
Unknown Object (File)
Sat, Feb 22, 1:50 AM
Unknown Object (File)
Thu, Feb 20, 5:05 PM
Unknown Object (File)
Feb 6 2025, 8:17 PM
Unknown Object (File)
Feb 4 2025, 7:04 PM
View All 25 Files
Subscribers
bapt
imp

Details

Reviewers
pjd
jamie
emaste
Commits
rG08eab7b3eb49: osd: Constify signature of osd_register()
rG63abb6a3b5d4: osd: Constify signature of osd_register()
rG4a26b63145a5: osd: Constify signature of osd_register()
Summary

This makes it clear that 'methods' (if not NULL) points to an array that
won't be modified. Internally, this array is indeed copied into the
given OSD type's larger array of all methods for all slots.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59693
Build 56579: arc lint + arc unit

Revision Contents
Changeset List

PathSize
share/
man/
man9/
4 lines
sys/
kern/
2 lines
sys/
2 lines

Diff 144170

View Options

share/man/man9/osd.9

Show All 17 Lines
.\" ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL .\" ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
.\" DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS .\" DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
.\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) .\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
.\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT .\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
.\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY .\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
.\" SUCH DAMAGE. .\" SUCH DAMAGE.
.\" .\"
.Dd April 26, 2016 .Dd July 01, 2024
.Dt OSD 9 .Dt OSD 9
.Os .Os
.Sh NAME .Sh NAME
.Nm osd , .Nm osd ,
.Nm osd_register , .Nm osd_register ,
.Nm osd_deregister , .Nm osd_deregister ,
.Nm osd_set , .Nm osd_set ,
.Nm osd_reserve , .Nm osd_reserve ,
Show All 9 Lines
.Ft typedef void .Ft typedef void
.Fn "\*(lp*osd_destructor_t\*(rp" "void *value" .Fn "\*(lp*osd_destructor_t\*(rp" "void *value"
.Ft typedef int .Ft typedef int
.Fn "\*(lp*osd_method_t\*(rp" "void *obj" "void *data" .Fn "\*(lp*osd_method_t\*(rp" "void *obj" "void *data"
.Ft int .Ft int
.Fo osd_register .Fo osd_register
.Fa "u_int type" .Fa "u_int type"
.Fa "osd_destructor_t destructor" .Fa "osd_destructor_t destructor"
.Fa "osd_method_t *methods" .Fa "const osd_method_t *methods"
.Fc .Fc
.Ft void .Ft void
.Fo osd_deregister .Fo osd_deregister
.Fa "u_int type" .Fa "u_int type"
.Fa "u_int slot" .Fa "u_int slot"
.Fc .Fc
.Ft int .Ft int
.Fo osd_set .Fo osd_set
▲ Show 20 Lines • Show All 388 Lines • Show Last 20 Lines
View Options

sys/kern/kern_osd.c

Show First 20 Lines • Show All 84 Lines • ▼ Show 20 Lines
static void static void
osd_default_destructor(void *value __unused) osd_default_destructor(void *value __unused)
{ {
/* Do nothing. */ /* Do nothing. */
} }
int int
osd_register(u_int type, osd_destructor_t destructor, osd_method_t *methods) osd_register(u_int type, osd_destructor_t destructor, const osd_method_t *methods)
{ {
void *newptr; void *newptr;
u_int i, m; u_int i, m;
KASSERT(type >= OSD_FIRST && type <= OSD_LAST, ("Invalid type.")); KASSERT(type >= OSD_FIRST && type <= OSD_LAST, ("Invalid type."));
/* /*
* If no destructor is given, use default one. We need to use some * If no destructor is given, use default one. We need to use some
▲ Show 20 Lines • Show All 342 Lines • Show Last 20 Lines
View Options

sys/sys/osd.h

Show First 20 Lines • Show All 49 Lines • ▼ Show 20 Lines
#define OSD_FIRST OSD_THREAD #define OSD_FIRST OSD_THREAD
#define OSD_LAST OSD_KHELP #define OSD_LAST OSD_KHELP
typedef void (*osd_destructor_t)(void *value); typedef void (*osd_destructor_t)(void *value);
typedef int (*osd_method_t)(void *obj, void *data); typedef int (*osd_method_t)(void *obj, void *data);
int osd_register(u_int type, osd_destructor_t destructor, int osd_register(u_int type, osd_destructor_t destructor,
osd_method_t *methods); const osd_method_t *methods);
void osd_deregister(u_int type, u_int slot); void osd_deregister(u_int type, u_int slot);
int osd_set(u_int type, struct osd *osd, u_int slot, void *value); int osd_set(u_int type, struct osd *osd, u_int slot, void *value);
void **osd_reserve(u_int slot); void **osd_reserve(u_int slot);
int osd_set_reserved(u_int type, struct osd *osd, u_int slot, void **rsv, int osd_set_reserved(u_int type, struct osd *osd, u_int slot, void **rsv,
void *value); void *value);
void osd_free_reserved(void **rsv); void osd_free_reserved(void **rsv);
void *osd_get(u_int type, struct osd *osd, u_int slot); void *osd_get(u_int type, struct osd *osd, u_int slot);
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines