pf tests: Remove nargs from single arguments
ClosedPublic
Actions

Authored by vegeta_tuxpowered.net on Sep 24 2024, 3:22 PM.

Details

Reviewers

Commits

rG6aeaadf68def: pf tests: Remove nargs from single arguments

Summary

Using nargs=1 causes arguments to produce lists from which we must then
get the real value. The same applies to defaults, the must be provided
as arrays too.

Remove nargs=1 so that values and defaults can be accessed directly.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

vegeta_tuxpowered.net created this revision.Sep 24 2024, 3:22 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptSep 24 2024, 3:22 PM

vegeta_tuxpowered.net requested review of this revision.Sep 24 2024, 3:22 PM

This seems to include a move to sys/netpfil/common/pft_ping.py, but not the makefile changes that would require. I assume the move is not intended to be part of this patch?

Other than that this looks good, so when my test run completes I intend to commit this without the move.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 25 2024, 10:44 AM

Closed by commit rG6aeaadf68def: pf tests: Remove nargs from single arguments (authored by vegeta_tuxpowered.net, committed by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG6aeaadf68def: pf tests: Remove nargs from single arguments.