Page MenuHomeFreeBSD

pf tests: Remove nargs from single arguments
ClosedPublic

Authored by vegeta_tuxpowered.net on Sep 24 2024, 3:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 3:31 AM
Unknown Object (File)
Jan 29 2025, 11:23 AM
Unknown Object (File)
Jan 29 2025, 3:05 AM
Unknown Object (File)
Jan 29 2025, 2:56 AM
Unknown Object (File)
Jan 28 2025, 12:46 AM
Unknown Object (File)
Jan 27 2025, 4:27 PM
Unknown Object (File)
Jan 14 2025, 10:19 PM
Unknown Object (File)
Jan 14 2025, 7:50 PM

Details

Summary

Using nargs=1 causes arguments to produce lists from which we must then
get the real value. The same applies to defaults, the must be provided
as arrays too.

Remove nargs=1 so that values and defaults can be accessed directly.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This seems to include a move to sys/netpfil/common/pft_ping.py, but not the makefile changes that would require. I assume the move is not intended to be part of this patch?

Other than that this looks good, so when my test run completes I intend to commit this without the move.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 25 2024, 10:44 AM
This revision was automatically updated to reflect the committed changes.