Assert that mbufs are writable if we write to them
ClosedPublic
Actions

Authored by kp on Sep 10 2024, 8:19 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jan 20, 7:21 AM

	Unknown Object (File)
	Tue, Jan 20, 2:00 AM

	Unknown Object (File)
	Sun, Jan 18, 2:33 PM

	Unknown Object (File)
	Fri, Jan 2, 6:25 AM

	Unknown Object (File)
	Dec 16 2025, 8:47 PM

	Unknown Object (File)
	Nov 3 2025, 2:19 PM

	Unknown Object (File)
	Oct 29 2025, 10:29 AM

	Unknown Object (File)
	Oct 29 2025, 7:49 AM

Subscribers

Details

Reviewers

glebius

Group Reviewers

network
pfsense

Commits

rGf08247fd888e: Assert that mbufs are writable if we write to them

Summary

m_copyback() modifies the mbuf, so it must be a writable mbuf.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59427
Build 56314: arc lint + arc unit

Event Timeline

kp created this revision.Sep 10 2024, 8:19 PM

Herald added subscribers: olce, glebius, imp. · View Herald TranscriptSep 10 2024, 8:19 PM

kp requested review of this revision.Sep 10 2024, 8:19 PM

Harbormaster completed remote builds in B59427: Diff 143210.Sep 10 2024, 8:20 PM

glebius accepted this revision.Sep 11 2024, 1:55 AM

This revision is now accepted and ready to land.Sep 11 2024, 1:55 AM

Closed by commit rGf08247fd888e: Assert that mbufs are writable if we write to them (authored by kp). · Explain WhySep 11 2024, 11:18 AM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGf08247fd888e: Assert that mbufs are writable if we write to them.

kp added a reverting change: rG299175f2e52e: Revert "Assert that mbufs are writable if we write to them".Sep 11 2024, 3:06 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

uipc_mbuf.c

2 lines

Diff 143210

View Options

Assert that mbufs are writable if we write to themClosedPublicActions