For now, opargs are not validated due to their runtime nature.
While here, improve parser a little and fix comment style.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 59254 Build 56141: arc lint + arc unit
Event Timeline
Comment Actions
I usually prefer having whitespace/comment cleanup work be a separate commit. That makes reviewing things that much easier.
There's no need to separate it out now, but it's something to keep in mind for future commits.
| sys/net/dummymbuf.c | ||
|---|---|---|
| 226 | We also set this in line 232. I don't see any obvious reason to set it here and then again later, so one of them should go away. | |
| sys/net/dummymbuf.c | ||
|---|---|---|
| 226 | Currently implemented parser error reporting tries to report only the rule it stopped at. During the recent testing I found a case when ; is missing, then nothing is printed back due to syntax_len=0. There is a little cons (probably it seems so only for me) if it prints everything from the cursor till the end -- it might form a feeling like the whole rule set is printed, while it's not. What do you think? I'm open for any direction. | |
Comment Actions
Approved.
| sys/net/dummymbuf.c | ||
|---|---|---|
| 226 | Ah, I think I see. | |
Comment Actions
Thanks for reminding. My feeling of little style updates probably has gone too far. I would like to separate it for the sake of good history/example.