Page MenuHomeFreeBSD
Differential D46279

riscv: Add machine/ifunc.h corresponding to rtld-elf's resolver interface
ClosedPublic
Actions

Authored by jrtc27 on Aug 13 2024, 4:25 AM.
Tags
None
Referenced Files
F169470591: D46279.id.diff
Tue, Sep 1, 3:12 PM
F169431097: D46279.diff
Tue, Sep 1, 12:56 PM
F169298253: D46279.id142032.diff
Tue, Sep 1, 3:51 AM
F169298213: D46279.id142360.diff
Tue, Sep 1, 3:51 AM
Unknown Object (File)
Sun, Aug 30, 11:33 AM
Unknown Object (File)
Sun, Aug 30, 10:02 AM
Unknown Object (File)
Thu, Aug 27, 7:06 AM
Unknown Object (File)
Thu, Aug 27, 6:54 AM
View All Files
Subscribers
imp
mhorne

Details

Reviewers
kib
fuz
mhorne
Group Reviewers
riscv
Commits
rG09e84ec73eef: riscv: Add machine/ifunc.h corresponding to rtld-elf's resolver interface
rGc700f3b25298: riscv: Add machine/ifunc.h corresponding to rtld-elf's resolver interface
rG8afae0caf4c4: riscv: Add machine/ifunc.h corresponding to rtld-elf's resolver interface

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jrtc27 created this revision.Aug 13 2024, 4:25 AM
Herald added a subscriber: imp. · View Herald TranscriptAug 13 2024, 4:25 AM
jrtc27 requested review of this revision.Aug 13 2024, 4:25 AM
Harbormaster completed remote builds in B59000: Diff 142032.Aug 13 2024, 4:25 AM
jrtc27 added a parent revision: D46278: rtld-elf: Support IFUNCs on riscv.Aug 13 2024, 4:26 AM
kib accepted this revision.Aug 13 2024, 8:55 AM
kib added inline comments.
sys/riscv/include/ifunc.h
6

Part of this software.

This revision is now accepted and ready to land.Aug 13 2024, 8:55 AM
fuz added a comment.Aug 14 2024, 6:24 PM

This also looks reasonable. Thank you for taking your time writing this patch.

mhorne accepted this revision.Aug 20 2024, 5:09 PM
mhorne added a subscriber: mhorne.
mhorne added inline comments.
sys/riscv/include/ifunc.h
41

Is u_long being purposely avoided here?

jrtc27 added inline comments.Aug 20 2024, 5:10 PM
sys/riscv/include/ifunc.h
41

I was under the impression we were deprecating the various u_ types? That could just be u_intX_t though, but at the same time u_long is a somewhat pointless typedef, it's just a shortened name, rather than abstracting something.

Closed by commit rG8afae0caf4c4: riscv: Add machine/ifunc.h corresponding to rtld-elf's resolver interface (authored by jrtc27). · Explain WhyAug 22 2024, 7:37 PM
This revision was automatically updated to reflect the committed changes.
jrtc27 added a commit: rG8afae0caf4c4: riscv: Add machine/ifunc.h corresponding to rtld-elf's resolver interface.
jrtc27 marked an inline comment as done.Aug 22 2024, 7:38 PM
jrtc27 added a commit: rGc700f3b25298: riscv: Add machine/ifunc.h corresponding to rtld-elf's resolver interface.Dec 15 2025, 5:01 PM
jrtc27 added a commit: rG09e84ec73eef: riscv: Add machine/ifunc.h corresponding to rtld-elf's resolver interface.Dec 15 2025, 6:19 PM

Revision Contents
Changeset List

PathSize
sys/
riscv/
include/
49 lines

Diff 142360

View Options

sys/riscv/include/ifunc.h

Loading...