axgbe: use bit_foreach
ClosedPublic
Actions

Authored by dougm on Jul 18 2024, 10:29 PM.

Details

Reviewers

markj
manu
des

Commits

rGb70247df0ba4: axgbe: use bit_foreach

Summary

bitstring.h includes a definition of bit_foreach, for iterating over the set bits of a bitstring. axgbe implements its own version of this for bitstrings. Drop it, and use the bitstring method.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm requested review of this revision.Jul 18 2024, 10:29 PM

dougm created this revision.

dougm added a subscriber: alc.Jul 19 2024, 2:15 AM

dougm added a reviewer: manu.Jul 20 2024, 5:09 AM

dougm added a reviewer: des.Aug 8 2024, 6:08 AM

des requested changes to this revision.Aug 9 2024, 3:14 PM

des added inline comments.

sys/dev/axgbe/xgbe-dev.c
829

This revision now requires changes to proceed.Aug 9 2024, 3:14 PM

dougm updated this revision to Diff 141952.Aug 9 2024, 4:36 PM

des accepted this revision.Aug 12 2024, 8:34 PM

This revision is now accepted and ready to land.Aug 12 2024, 8:34 PM

Closed by commit rGb70247df0ba4: axgbe: use bit_foreach (authored by dougm). · Explain WhyAug 12 2024, 9:06 PM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rGb70247df0ba4: axgbe: use bit_foreach.

Herald added a subscriber: imp. · View Herald TranscriptAug 12 2024, 9:06 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

axgbe/

xgbe-dev.c

7 lines

xgbe_osdep.h

66 lines

Diff 142021

View Options

sys/dev/axgbe/xgbe-dev.c