Page MenuHomeFreeBSD
Differential D46267

faccessat(2): Honor AT_SYMLINK_NOFOLLOW
ClosedPublic
Actions

Authored by fernape on Aug 10 2024, 11:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 17, 4:01 AM
Unknown Object (File)
Mon, Jul 7, 5:56 AM
Unknown Object (File)
Mon, Jun 30, 11:30 AM
Unknown Object (File)
Sun, Jun 29, 7:44 AM
Unknown Object (File)
Jun 27 2025, 2:58 AM
Unknown Object (File)
Jun 25 2025, 12:21 PM
Unknown Object (File)
Jun 23 2025, 10:49 PM
Unknown Object (File)
Jun 23 2025, 9:11 PM
View All 80 Files
Subscribers
imp
olce

Details

Reviewers
kib
Commits
rGddbbc129ae0f: faccessat(2): Honor AT_SYMLINK_NOFOLLOW
rG5ab6ed93cd36: faccessat(2): Honor AT_SYMLINK_NOFOLLOW
Summary

Make the system call honor AT_SYMLINK_NOFOLLOW.

Also enable this from linux_faccessat2 where the issue arised the first time.
Update manual pages accordingly.

PR: 275295

Test Plan

Apply the patch and use a simple program to test the system call.
One such program can be found here.

AFAICT, this change is POSIX-compliant.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 58986
Build 55873: arc lint + arc unit

Event Timeline

fernape created this revision.Aug 10 2024, 11:45 AM
Herald added subscribers: olce, imp. · View Herald TranscriptAug 10 2024, 11:45 AM
fernape requested review of this revision.Aug 10 2024, 11:45 AM
Harbormaster completed remote builds in B58982: Diff 141976.Aug 10 2024, 11:46 AM
fernape edited the summary of this revision. (Show Details)Aug 10 2024, 11:47 AM
fernape edited the test plan for this revision. (Show Details)
fernape added a reviewer: kib.
kib added a comment.Aug 10 2024, 10:36 PM

Do not forget to bump the man page's dates.

sys/compat/linux/linux_file.c
639–640

This line should be wrapped.

sys/kern/vfs_syscalls.c
2154–2155

The line should be wrapped. I do not see a need to add {} around the body.

fernape updated this revision to Diff 141987.Aug 11 2024, 10:34 AM
  • Address kib's feedback.
Harbormaster completed remote builds in B58984: Diff 141987.Aug 11 2024, 10:34 AM
fernape marked 2 inline comments as done.Aug 11 2024, 10:34 AM
In D46267#1055079, @kib wrote:

Do not forget to bump the man page's dates.

Yes, I will bump .Dd at commit time.

kib added inline comments.Aug 11 2024, 10:50 AM
sys/compat/linux/linux_file.c
640

Indent for the continuation line should be +4 spaces

sys/kern/vfs_syscalls.c
46

Stray chunk

2155

Again, indent should be +4 spaces

fernape updated this revision to Diff 141988.Aug 11 2024, 12:13 PM
  • Use +4 spaces for indentation.
Harbormaster completed remote builds in B58985: Diff 141988.Aug 11 2024, 12:13 PM
fernape updated this revision to Diff 141989.Aug 11 2024, 12:14 PM
fernape marked 2 inline comments as done.
  • Remove stray change.
Harbormaster completed remote builds in B58986: Diff 141989.Aug 11 2024, 12:14 PM
fernape marked an inline comment as done.Aug 11 2024, 12:14 PM
kib accepted this revision.Aug 11 2024, 12:19 PM
This revision is now accepted and ready to land.Aug 11 2024, 12:19 PM
Closed by commit rG5ab6ed93cd36: faccessat(2): Honor AT_SYMLINK_NOFOLLOW (authored by fernape). · Explain WhyAug 11 2024, 3:54 PM
This revision was automatically updated to reflect the committed changes.
fernape added a commit: rG5ab6ed93cd36: faccessat(2): Honor AT_SYMLINK_NOFOLLOW.
emaste added a commit: rGddbbc129ae0f: faccessat(2): Honor AT_SYMLINK_NOFOLLOW.Sep 26 2024, 2:47 PM

Revision Contents
Changeset List

PathSize
bin/
ln/
1 line
lib/
libsys/
4 lines
sys/
compat/
linux/
6 lines
kern/
7 lines

Diff 141989

View Options

bin/ln/symlink.7

# Created by: Ben Woods <woodsb02@gmail.com> # Created by: Ben Woods <woodsb02@gmail.com>
# $FreeBSD$ # $FreeBSD$
PORTNAME= emby-server PORTNAME= emby-server
PORTVERSION= 3.0.5724.6 PORTVERSION= 3.0.5781.2
CATEGORIES= multimedia CATEGORIES= multimedia
MAINTAINER= woodsb02@gmail.com MAINTAINER= woodsb02@gmail.com
COMMENT= Home media server built using mono and other open source technologies COMMENT= Home media server built using mono and other open source technologies
LICENSE= GPLv2 LICENSE= GPLv2
LICENSE_FILE= ${WRKSRC}/LICENSE.md LICENSE_FILE= ${WRKSRC}/LICENSE.md
Show All 33 Lines
View Options

lib/libsys/access.2

# Created by: Ben Woods <woodsb02@gmail.com> # Created by: Ben Woods <woodsb02@gmail.com>
# $FreeBSD$ # $FreeBSD$
PORTNAME= emby-server PORTNAME= emby-server
PORTVERSION= 3.0.5724.6 PORTVERSION= 3.0.5781.2
CATEGORIES= multimedia CATEGORIES= multimedia
MAINTAINER= woodsb02@gmail.com MAINTAINER= woodsb02@gmail.com
COMMENT= Home media server built using mono and other open source technologies COMMENT= Home media server built using mono and other open source technologies
LICENSE= GPLv2 LICENSE= GPLv2
LICENSE_FILE= ${WRKSRC}/LICENSE.md LICENSE_FILE= ${WRKSRC}/LICENSE.md
Show All 33 Lines
View Options

sys/compat/linux/linux_file.c

# Created by: Ben Woods <woodsb02@gmail.com> # Created by: Ben Woods <woodsb02@gmail.com>
# $FreeBSD$ # $FreeBSD$
PORTNAME= emby-server PORTNAME= emby-server
PORTVERSION= 3.0.5724.6 PORTVERSION= 3.0.5781.2
CATEGORIES= multimedia CATEGORIES= multimedia
MAINTAINER= woodsb02@gmail.com MAINTAINER= woodsb02@gmail.com
COMMENT= Home media server built using mono and other open source technologies COMMENT= Home media server built using mono and other open source technologies
LICENSE= GPLv2 LICENSE= GPLv2
LICENSE_FILE= ${WRKSRC}/LICENSE.md LICENSE_FILE= ${WRKSRC}/LICENSE.md
Show All 33 Lines
View Options

sys/kern/vfs_syscalls.c

# Created by: Ben Woods <woodsb02@gmail.com> # Created by: Ben Woods <woodsb02@gmail.com>
# $FreeBSD$ # $FreeBSD$
PORTNAME= emby-server PORTNAME= emby-server
PORTVERSION= 3.0.5724.6 PORTVERSION= 3.0.5781.2
CATEGORIES= multimedia CATEGORIES= multimedia
MAINTAINER= woodsb02@gmail.com MAINTAINER= woodsb02@gmail.com
COMMENT= Home media server built using mono and other open source technologies COMMENT= Home media server built using mono and other open source technologies
LICENSE= GPLv2 LICENSE= GPLv2
LICENSE_FILE= ${WRKSRC}/LICENSE.md LICENSE_FILE= ${WRKSRC}/LICENSE.md
Show All 33 Lines