Page MenuHomeFreeBSD
Differential D5586

agp: Do not attach to Intel GEN6+
ClosedPublic
Actions

Authored by dumbbell on Mar 8 2016, 10:25 PM.
Tags
None
Referenced Files
F83953831: D5586.diff
Fri, May 17, 8:20 AM
Unknown Object (File)
Wed, May 8, 10:14 AM
Unknown Object (File)
Fri, May 3, 11:07 PM
Unknown Object (File)
Dec 22 2023, 9:24 PM
Unknown Object (File)
Oct 1 2023, 2:41 PM
Unknown Object (File)
Sep 13 2023, 4:34 AM
Unknown Object (File)
Sep 5 2023, 8:29 AM
Unknown Object (File)
Sep 5 2023, 8:26 AM
View All 53 Files
Subscribers
imp

Details

Reviewers
kib
jhb
zeising
kwm
Commits
rS296719: agp: Do not attach to Intel GEN6+
Summary

The i915 video driver doesn't depend on agp(4) anymore for Sandybridge and later GPUs. Therefore, there is no need to attach agp(4) to those devices.

kib@, I noticed that the agp_g4x_res_spec variable was used by all GEN6+, but not by G4X. Is is expected?

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2824
Build 2848: arc lint + arc unit

Event Timeline

dumbbell updated this revision to Diff 14177.Mar 8 2016, 10:25 PM
dumbbell retitled this revision from to agp: Do not attach to Intel GEN6+.
dumbbell updated this object.
dumbbell edited the test plan for this revision. (Show Details)
dumbbell added reviewers: jhb, kib, kwm, zeising.
Herald added a subscriber: imp. · View Herald TranscriptMar 8 2016, 10:25 PM
kib accepted this revision.Mar 9 2016, 12:21 PM
kib edited edge metadata.

About agp_g4x_res_spec, I think that it actually does not matter. I re-read GMCH datasheets for 965, G45 and SandyBridge. On all three chipsets, device 0:2:0 BAR at 0x10 is combined mmio and GTT, and BAR at 0x18 is the aperture. So the correct thing to do is to add a name for 965 BAR at 0x18 and add a second resource line to agp_i965_res_spec, which should be used by Gen4+.

I think that i965 and g4x res_specs where split due to my mistake.

This revision is now accepted and ready to land.Mar 9 2016, 12:21 PM
kwm edited edge metadata.Mar 10 2016, 10:52 PM

This patch works fine on my sandybridge system.

dumbbell updated this revision to Diff 14240.Mar 11 2016, 5:52 PM
dumbbell edited edge metadata.

Fix agp_i965_res_spec

This revision now requires review to proceed.Mar 11 2016, 5:52 PM
kib accepted this revision.Mar 12 2016, 4:21 AM
kib edited edge metadata.

Can we leave the AGP_SNB registers definitions in the header ? I find it easier to consult our reg.h than to search datasheets.

This revision is now accepted and ready to land.Mar 12 2016, 4:21 AM
Closed by commit rS296719: agp: Do not attach to Intel GEN6+ (authored by dumbbell). · Explain WhyMar 12 2016, 9:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
agp/
497 lines

Diff 14177

View Options

sys/dev/agp/agp_i810.c

Loading...