Page MenuHomeFreeBSD
Differential D46100

sound: Simplify feeder_remove()
ClosedPublic
Actions

Authored by christos on Jul 24 2024, 3:44 PM.
Tags
None
Referenced Files
F171847495: D46100.id.diff
Mon, Sep 14, 1:09 AM
Unknown Object (File)
Sat, Sep 12, 4:45 PM
Unknown Object (File)
Sat, Sep 12, 6:03 AM
Unknown Object (File)
Sat, Sep 12, 12:30 AM
Unknown Object (File)
Fri, Sep 11, 11:45 AM
Unknown Object (File)
Wed, Sep 9, 8:46 AM
Unknown Object (File)
Tue, Sep 8, 3:49 PM
Unknown Object (File)
Mon, Sep 7, 9:56 PM
View All Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rGa9e27006db60: sound: Simplify feeder_remove()
rG00172d20070a: sound: Simplify feeder_remove()
Summary

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58806
Build 55693: arc lint + arc unit

Event Timeline

christos created this revision.Jul 24 2024, 3:44 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 24 2024, 3:44 PM
christos requested review of this revision.Jul 24 2024, 3:44 PM
Harbormaster completed remote builds in B58801: Diff 141312.Jul 24 2024, 3:44 PM
christos mentioned this in D45979: sound: Fix memory leak in chn_init().Jul 24 2024, 3:45 PM
markj added inline comments.Jul 24 2024, 4:26 PM
sys/dev/sound/pcm/feeder.c
258

These three lines can be replaced by while (c->feeder != NULL).

christos updated this revision to Diff 141322.Jul 24 2024, 7:13 PM
christos marked an inline comment as done.

Address Mark's comment.

Harbormaster completed remote builds in B58806: Diff 141322.Jul 24 2024, 7:13 PM
markj accepted this revision.Jul 25 2024, 12:52 PM
This revision is now accepted and ready to land.Jul 25 2024, 12:52 PM
dev_submerge.ch accepted this revision.Jul 25 2024, 1:29 PM
emaste accepted this revision.Jul 25 2024, 1:34 PM
Closed by commit rG00172d20070a: sound: Simplify feeder_remove() (authored by christos). · Explain WhyJul 27 2024, 11:58 AM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG00172d20070a: sound: Simplify feeder_remove().
christos added a commit: rGa9e27006db60: sound: Simplify feeder_remove().Jul 29 2024, 3:37 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
6 lines
2 lines
14 lines
3 lines

Diff 141322

View Options

sys/dev/sound/pcm/channel.c

Loading...
View Options

sys/dev/sound/pcm/feeder.h

Loading...
View Options

sys/dev/sound/pcm/feeder.c

Loading...
View Options

sys/dev/sound/pcm/feeder_chain.c

Loading...