Page MenuHomeFreeBSD
Differential D45979

sound: Fix memory leak in chn_init()
ClosedPublic
Actions

Authored by christos on Jul 15 2024, 3:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 31, 12:34 PM
Unknown Object (File)
Wed, Aug 26, 1:46 PM
Unknown Object (File)
Tue, Aug 25, 4:27 PM
Unknown Object (File)
Tue, Aug 25, 1:02 PM
Unknown Object (File)
Sat, Aug 22, 1:28 PM
Unknown Object (File)
Sat, Aug 22, 1:26 PM
Unknown Object (File)
Sat, Aug 15, 4:31 PM
Unknown Object (File)
Sat, Aug 8, 3:13 AM
View All Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rG6716cc7e2768: sound: Fix memory leak in chn_init()
rG16329b7b3276: sound: Fix memory leak in chn_init()
Summary

In case chn_init() fails, we are leaking memory by not freeing the
feeder.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Jul 15 2024, 3:58 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 15 2024, 3:58 PM
christos requested review of this revision.Jul 15 2024, 3:58 PM
Harbormaster completed remote builds in B58651: Diff 140973.Jul 15 2024, 3:58 PM
christos added a child revision: D45985: sound: Simplify chn_init().Jul 17 2024, 1:13 AM
dev_submerge.ch accepted this revision.Jul 19 2024, 12:01 AM
This revision is now accepted and ready to land.Jul 19 2024, 12:01 AM
markj accepted this revision.Jul 21 2024, 4:13 PM
markj added inline comments.
sys/dev/sound/pcm/channel.c
1369

Since this strange-looking while loop appears in several places now, it would a good idea to move it into a subroutine.

christos added inline comments.Jul 22 2024, 11:19 AM
sys/dev/sound/pcm/channel.c
1369

Maybe it's better to just modify the function directly?

markj added inline comments.Jul 22 2024, 2:02 PM
sys/dev/sound/pcm/channel.c
1369

That works too.

christos marked 2 inline comments as done.Jul 24 2024, 3:45 PM
christos added inline comments.
sys/dev/sound/pcm/channel.c
1369

@markj D46100

Closed by commit rG16329b7b3276: sound: Fix memory leak in chn_init() (authored by christos). · Explain WhyJul 27 2024, 11:58 AM
This revision was automatically updated to reflect the committed changes.
christos marked an inline comment as done.
christos added a commit: rG16329b7b3276: sound: Fix memory leak in chn_init().
christos added a commit: rG6716cc7e2768: sound: Fix memory leak in chn_init().Jul 29 2024, 3:36 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
2 lines

Diff 141462

View Options

sys/dev/sound/pcm/channel.c

Loading...