ministat: Consistently use item count as the first argument to calloc
ClosedPublic
Actions

Authored by jhb on Jul 17 2024, 7:16 PM.

Details

Reviewers

imp
emaste
rlibby

Commits

rGf9c59a50a327: ministat: Consistently use item count as the first argument to calloc
rG263483280cbc: ministat: Consistently use item count as the first argument to calloc
rGa971c6045622: ministat: Consistently use item count as the first argument to calloc

Summary

Reported by: GCC 14 -Wcalloc-transposed-args

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Jul 17 2024, 7:16 PM

jhb created this revision.

Harbormaster completed remote builds in B58693: Diff 141061.Jul 17 2024, 7:16 PM

jhb added a parent revision: D46010: recoverdisk: Consistently use item count as the first argument to calloc.Jul 17 2024, 7:16 PM

jhb added a child revision: D46012: bsdinstall: Consistently use item count as the first argument to calloc.

rlibby accepted this revision.Jul 17 2024, 7:55 PM

This revision is now accepted and ready to land.Jul 17 2024, 7:55 PM

emaste accepted this revision.Jul 17 2024, 8:57 PM

Closed by commit rGa971c6045622: ministat: Consistently use item count as the first argument to calloc (authored by jhb). · Explain WhyJul 19 2024, 5:08 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGa971c6045622: ministat: Consistently use item count as the first argument to calloc.

jhb added a commit: rG263483280cbc: ministat: Consistently use item count as the first argument to calloc.Nov 30 2024, 4:52 PM

jhb added a commit: rGf9c59a50a327: ministat: Consistently use item count as the first argument to calloc.

Revision Contents
Changeset List

Path

Size

usr.bin/

ministat/

ministat.c

6 lines

Diff 141152

View Options

usr.bin/ministat/ministat.c

Show All 38 Lines

.Dt NVMECONTROL 8

.Os

.Sh NAME

.Nm nvmecontrol

.Nd NVM Express control utility

.Sh SYNOPSIS

.Nm

.Ic devlist

.Op Fl h

.Nm

.Ic identify

.Op Fl v

.Op Fl x

.Op Fl n Ar nsid

.Aq Ar device-id | Ar namespace-id

.Nm

.Ic perftest

▲ Show 20 Lines • Show All 149 Lines • ▼ Show 20 Lines

.Aq Ar device-id

.Nm

.Ic io-passthru

.Op args

.Aq Ar namespace-id

.Sh DESCRIPTION

NVM Express (NVMe) is a storage protocol standard, for SSDs and other

high-speed storage devices over PCI Express.

.Ss devlist

List all NVMe controllers and namespaces along with their device nodes.

With the

.Fl h

argument, use unit suffixes: Byte, Kibibyte, Mebibyte, Gibibyte, Tebibyte

and Pebibyte (based on powers of 1024) when showing the disk space.

By default, uses Mebibyte.

pauamma_gundo.comUnsubmitted

Not Done

and Pebibyte (based on powers of 1024) when showing the disk space.

- By default, shows in Mebityte.

+ By default, shows in Mebibyte.

.Ss identify

Maybe also s/shows in/uses/ for consistency with the previous sentence, but that's a matter of taste. The typo itself is the important thing.

pauamma_gundo.com: Maybe also s/shows in/uses/ for consistency with the previous sentence, but that's a matter of…

.Ss identify

The identify commands reports information from the drive's

.Dv IDENTIFY_CONTROLLER

if a

.Ar device-id

is specified.

It reports

.Dv IDENTIFY_NAMESPACE

▲ Show 20 Lines • Show All 530 Lines • Show Last 20 Lines

ministat: Consistently use item count as the first argument to callocClosedPublicActions