Differential D46011

ministat: Consistently use item count as the first argument to calloc
ClosedPublic
Actions

Authored by jhb on Jul 17 2024, 7:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Mar 18, 12:55 PM

	Unknown Object (File)
	Tue, Mar 4, 5:53 AM

	Unknown Object (File)
	Feb 3 2025, 10:10 PM

	Unknown Object (File)
	Feb 2 2025, 11:32 AM

	Unknown Object (File)
	Jan 27 2025, 5:07 PM

	Unknown Object (File)
	Jan 27 2025, 3:20 AM

	Unknown Object (File)
	Jan 24 2025, 9:38 PM

	Unknown Object (File)
	Jan 13 2025, 12:48 AM

View All 71 Files

Subscribers

None

Details

Reviewers

imp
emaste
rlibby

Commits

rGf9c59a50a327: ministat: Consistently use item count as the first argument to calloc
rG263483280cbc: ministat: Consistently use item count as the first argument to calloc
rGa971c6045622: ministat: Consistently use item count as the first argument to calloc

Summary

Reported by: GCC 14 -Wcalloc-transposed-args

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58693
Build 55581: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Jul 17 2024, 7:16 PM

jhb created this revision.

Harbormaster completed remote builds in B58693: Diff 141061.Jul 17 2024, 7:16 PM

jhb added a parent revision: D46010: recoverdisk: Consistently use item count as the first argument to calloc.Jul 17 2024, 7:16 PM

jhb added a child revision: D46012: bsdinstall: Consistently use item count as the first argument to calloc.

rlibby accepted this revision.Jul 17 2024, 7:55 PM

This revision is now accepted and ready to land.Jul 17 2024, 7:55 PM

emaste accepted this revision.Jul 17 2024, 8:57 PM

Closed by commit rGa971c6045622: ministat: Consistently use item count as the first argument to calloc (authored by jhb). · Explain WhyJul 19 2024, 5:08 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGa971c6045622: ministat: Consistently use item count as the first argument to calloc.

jhb added a commit: rG263483280cbc: ministat: Consistently use item count as the first argument to calloc.Nov 30 2024, 4:52 PM

jhb added a commit: rGf9c59a50a327: ministat: Consistently use item count as the first argument to calloc.

Revision Contents
Changeset List

Path

Size

usr.bin/

ministat/

6 lines

Diff 141061

usr.bin/ministat/ministat.c

	# $FreeBSD$			# $FreeBSD$
	# Autogenerated - do NOT edit!			# Autogenerated - do NOT edit!

	DIRDEPS = \			DIRDEPS = \
	include \			include \
	include/xlocale \			include/xlocale \
	lib/${CSU_DIR} \			lib/${CSU_DIR} \
	lib/libc \			lib/libc \
	lib/libcompiler_rt \			lib/libcompiler_rt \
	lib/liblzma \			lib/liblzma \
	lib/libthr \			lib/libthr \
	lib/libz \			lib/libz \
				lib/libzstd \


	.include <dirdeps.mk>			.include <dirdeps.mk>

	.if ${DEP_RELDIR} == ${_DEP_RELDIR}			.if ${DEP_RELDIR} == ${_DEP_RELDIR}
	# local dependencies - needed for -jN in clean tree			# local dependencies - needed for -jN in clean tree
	.endif			.endif