Differential D46009

md5: Consistently use item count as the first argument to calloc
ClosedPublic
Actions

Authored by jhb on Jul 17 2024, 7:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jan 20, 2:43 AM

	Unknown Object (File)
	Sun, Jan 18, 10:22 AM

	Unknown Object (File)
	Dec 29 2025, 8:17 PM

	Unknown Object (File)
	Dec 26 2025, 7:34 PM

	Unknown Object (File)
	Dec 6 2025, 10:46 AM

	Unknown Object (File)
	Dec 1 2025, 9:13 PM

	Unknown Object (File)
	Nov 29 2025, 12:04 AM

	Unknown Object (File)
	Nov 27 2025, 4:51 PM

Subscribers

None

Details

Reviewers

imp
emaste
rlibby

Commits

rG7380c8ea849f: md5: Consistently use item count as the first argument to calloc
rG0c293d0425a7: md5: Consistently use item count as the first argument to calloc
rGe8e2ab3c5522: md5: Consistently use item count as the first argument to calloc

Summary

Reported by: GCC 14 -Wcalloc-transposed-args

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58691
Build 55579: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Jul 17 2024, 7:16 PM

jhb created this revision.

Harbormaster completed remote builds in B58691: Diff 141059.Jul 17 2024, 7:16 PM

jhb added a parent revision: D46008: lib80211: Consistently use item count as the first argument to calloc.Jul 17 2024, 7:16 PM

jhb added a child revision: D46010: recoverdisk: Consistently use item count as the first argument to calloc.

rlibby accepted this revision.Jul 17 2024, 7:54 PM

This revision is now accepted and ready to land.Jul 17 2024, 7:54 PM

Closed by commit rGe8e2ab3c5522: md5: Consistently use item count as the first argument to calloc (authored by jhb). · Explain WhyJul 19 2024, 5:08 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGe8e2ab3c5522: md5: Consistently use item count as the first argument to calloc.

jhb added a commit: rG0c293d0425a7: md5: Consistently use item count as the first argument to calloc.Nov 30 2024, 4:52 PM

jhb added a commit: rG7380c8ea849f: md5: Consistently use item count as the first argument to calloc.

Revision Contents
Changeset List

Path

Size

sbin/

md5/

2 lines

Diff 141059

sbin/md5/md5.c

Loading...