stdatomic: Only use clang atomics if clang is defined
ClosedPublic
Actions

Authored by jhb on Jul 17 2024, 7:14 PM.

Details

Reviewers

imp
emaste
rlibby

Commits

rG680f40f38343: stdatomic: Only use clang atomics if __clang__ is defined

Summary

GCC 14 defines has_extension(c_atomic) but does not support
c11_atomic_*, so require clang for the CLANG_ATOMICS case.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58683
Build 55571: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Jul 17 2024, 7:14 PM

jhb created this revision.

Harbormaster completed remote builds in B58683: Diff 141051.Jul 17 2024, 7:14 PM

jhb added a parent revision: D45995: openssl: Add <sys/random.h> include for getrandom().Jul 17 2024, 7:15 PM

jhb added a child revision: D46003: Merge commit cb7a03b41fff from llvm git (by Nikolas Klauser):.

We likely don't need sync atomics given the scopeof where it would be needed... but im not sure.

This revision is now accepted and ready to land.Jul 17 2024, 7:55 PM

I think as part of your cleanup of cdefs.h, we can probably drop the pre-GCC 4.7 path entirely. We already don't support versions of GCC that old in cdefs.h now I think?

emaste accepted this revision.Jul 17 2024, 8:46 PM

Closed by commit rG680f40f38343: stdatomic: Only use clang atomics if __clang__ is defined (authored by jhb). · Explain WhyJul 19 2024, 5:07 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG680f40f38343: stdatomic: Only use clang atomics if __clang__ is defined.

Revision Contents
Changeset List

Path

Size

sys/

stdatomic.h

3 lines

Diff 141051

View Options

stdatomic: Only use clang atomics if __clang__ is definedClosedPublicActions