dhclient: Ignore SIP servers DHCP option defined in RFC 3361
ClosedPublic
Actions

Authored by michaelo on Jul 4 2024, 6:13 PM.

Details

Reviewers

jrm
otis
brooks

Commits

rGe5236f640510: dhclient: Ignore SIP servers DHCP option defined in RFC 3361
rG954692a14402: dhclient: Ignore SIP servers DHCP option defined in RFC 3361
rGac6dc5cde729: dhclient: Ignore SIP servers DHCP option defined in RFC 3361

Summary

Ignore SIP servers dhcp option to shut up the warning message.
This option is defined in the RFC 3361 and sent from NSD-G1000T router.

PR: 280119

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michaelo created this revision.Jul 4 2024, 6:13 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 4 2024, 6:13 PM

michaelo requested review of this revision.Jul 4 2024, 6:13 PM

Harbormaster completed remote builds in B58498: Diff 140555.Jul 4 2024, 6:13 PM

Fix formatting

Harbormaster completed remote builds in B58499: Diff 140556.Jul 4 2024, 6:15 PM

Formatting again

Harbormaster completed remote builds in B58500: Diff 140557.Jul 4 2024, 6:15 PM

RFC 3361 declares 120 to be the code for the option, and this is doing the same thing as what's done for other unimplemented options, so this seems fine to me too. I'll add @brooks, a src committer who just touched dhclient, to be sure we're not missing something. Please make sure you use git commit --author to attribute Yuichiro NAITO in the commit logs.

This revision is now accepted and ready to land.Jul 4 2024, 6:35 PM

jrm added a reviewer: brooks.Jul 4 2024, 6:35 PM

Please also note the discussion in the PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280119

In D45873#1045890, @jrm wrote:

RFC 3361 declares 120 to be the code for the option, and this is doing the same thing as what's done for other unimplemented options, so this seems fine to me too. I'll add @brooks, a src committer who just touched dhclient, to be sure we're not missing something. Please make sure you use git commit --author to attribute Yuichiro NAITO in the commit logs.

Did that already, gave the reporter full credits.

Seems reasonable to me.

Closed by commit rGac6dc5cde729: dhclient: Ignore SIP servers DHCP option defined in RFC 3361 (authored by naito.yuichiro_gmail.com, committed by michaelo). · Explain WhyJul 15 2024, 5:44 PM

This revision was automatically updated to reflect the committed changes.

michaelo added a commit: rGac6dc5cde729: dhclient: Ignore SIP servers DHCP option defined in RFC 3361.

michaelo added a commit: rG954692a14402: dhclient: Ignore SIP servers DHCP option defined in RFC 3361.Jul 29 2024, 6:21 AM

michaelo added a commit: rGe5236f640510: dhclient: Ignore SIP servers DHCP option defined in RFC 3361.