Page MenuHomeFreeBSD
Differential D45680

include: ssp: fortify poll/ppoll from <poll.h>
ClosedPublic
Actions

Authored by kevans on Jun 21 2024, 4:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 27, 7:24 AM
Unknown Object (File)
Feb 13 2025, 3:18 PM
Unknown Object (File)
Jan 30 2025, 1:06 AM
Unknown Object (File)
Jan 24 2025, 10:29 AM
Unknown Object (File)
Jan 17 2025, 6:16 PM
Unknown Object (File)
Jan 17 2025, 3:43 PM
Unknown Object (File)
Jan 9 2025, 12:41 PM
Unknown Object (File)
Jan 9 2025, 12:00 PM
View All 79 Files
Subscribers
imp

Details

Reviewers
kib
markj
Group Reviewers
Klara
Commits
rG88276dfbf19e: include: ssp: fortify poll/ppoll from <poll.h>
Summary

For poll/ppoll we just need to bounds-check the poll array that we're
about to write out to.

Sponsored by: Stormshieled
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans created this revision.Jun 21 2024, 4:59 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 21 2024, 4:59 PM
kevans requested review of this revision.Jun 21 2024, 4:59 PM
Harbormaster completed remote builds in B58289: Diff 140081.Jun 21 2024, 4:59 PM
kevans added a parent revision: D45679: include: ssp: round out fortification of current set of headers.Jun 21 2024, 4:59 PM
kevans added a child revision: D45681: include: ssp: fortify <stdlib.h>.
markj added inline comments.Jun 24 2024, 4:54 PM
include/ssp/poll.h
3

Extra line here.

lib/libc/sys/ppoll.c
40–41

This line is too long.

markj accepted this revision as: markj.Jun 24 2024, 4:54 PM
This revision is now accepted and ready to land.Jun 24 2024, 4:54 PM
kevans marked 2 inline comments as done.Jun 26 2024, 7:11 PM
kevans added inline comments.
include/ssp/poll.h
3

Addressed here and all of the other headers since these were all copy/paste into each other.

kevans updated this revision to Diff 140280.Jun 26 2024, 7:12 PM
kevans marked an inline comment as done.

Address review feedback

This revision now requires review to proceed.Jun 26 2024, 7:12 PM
Harbormaster completed remote builds in B58366: Diff 140280.Jun 26 2024, 7:12 PM
kib accepted this revision.Jun 27 2024, 3:14 PM
This revision is now accepted and ready to land.Jun 27 2024, 3:14 PM
Closed by commit rG88276dfbf19e: include: ssp: fortify poll/ppoll from <poll.h> (authored by kevans). · Explain WhyJul 13 2024, 5:23 AM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rG88276dfbf19e: include: ssp: fortify poll/ppoll from <poll.h>.

Revision Contents
Changeset List

PathSize
include/
ssp/
2 lines
60 lines
lib/
libc/
sys/
5 lines
8 lines
tests/
secure/
1 line
fortify_poll_test.c
fortify_strings_test.c
34 lines
sys/
sys/
4 lines

Diff 140851

View Options

include/ssp/Makefile

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Lines
KDB opt_global.h KDB opt_global.h
KDB_TRACE opt_kdb.h KDB_TRACE opt_kdb.h
KDB_UNATTENDED opt_kdb.h KDB_UNATTENDED opt_kdb.h
KLD_DEBUG opt_kld.h KLD_DEBUG opt_kld.h
SYSCTL_DEBUG opt_sysctl.h SYSCTL_DEBUG opt_sysctl.h
EARLY_PRINTF opt_global.h EARLY_PRINTF opt_global.h
TEXTDUMP_PREFERRED opt_ddb.h TEXTDUMP_PREFERRED opt_ddb.h
TEXTDUMP_VERBOSE opt_ddb.h TEXTDUMP_VERBOSE opt_ddb.h
NUM_CORES opt_global.h
sjgUnsubmitted
Not Done
Inline Actions

I know NUM_CORES makes sense given the code in kern_sig,c
but NUM_CORE_FILES might be more meaningful here?

sjg: I know NUM_CORES makes sense given the code in kern_sig,c but NUM_CORE_FILES might be more…
# Miscellaneous options. # Miscellaneous options.
ADAPTIVE_LOCKMGRS ADAPTIVE_LOCKMGRS
ALQ ALQ
ALTERA_SDCARD_FAST_SIM opt_altera_sdcard.h ALTERA_SDCARD_FAST_SIM opt_altera_sdcard.h
ATSE_CFI_HACK opt_cfi.h ATSE_CFI_HACK opt_cfi.h
AUDIT opt_global.h AUDIT opt_global.h
BOOTHOWTO opt_global.h BOOTHOWTO opt_global.h
▲ Show 20 Lines • Show All 912 Lines • Show Last 20 Lines
View Options

include/ssp/poll.h

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Lines
KDB opt_global.h KDB opt_global.h
KDB_TRACE opt_kdb.h KDB_TRACE opt_kdb.h
KDB_UNATTENDED opt_kdb.h KDB_UNATTENDED opt_kdb.h
KLD_DEBUG opt_kld.h KLD_DEBUG opt_kld.h
SYSCTL_DEBUG opt_sysctl.h SYSCTL_DEBUG opt_sysctl.h
EARLY_PRINTF opt_global.h EARLY_PRINTF opt_global.h
TEXTDUMP_PREFERRED opt_ddb.h TEXTDUMP_PREFERRED opt_ddb.h
TEXTDUMP_VERBOSE opt_ddb.h TEXTDUMP_VERBOSE opt_ddb.h
NUM_CORES opt_global.h
sjgUnsubmitted
Not Done
Inline Actions

I know NUM_CORES makes sense given the code in kern_sig,c
but NUM_CORE_FILES might be more meaningful here?

sjg: I know NUM_CORES makes sense given the code in kern_sig,c but NUM_CORE_FILES might be more…
# Miscellaneous options. # Miscellaneous options.
ADAPTIVE_LOCKMGRS ADAPTIVE_LOCKMGRS
ALQ ALQ
ALTERA_SDCARD_FAST_SIM opt_altera_sdcard.h ALTERA_SDCARD_FAST_SIM opt_altera_sdcard.h
ATSE_CFI_HACK opt_cfi.h ATSE_CFI_HACK opt_cfi.h
AUDIT opt_global.h AUDIT opt_global.h
BOOTHOWTO opt_global.h BOOTHOWTO opt_global.h
▲ Show 20 Lines • Show All 912 Lines • Show Last 20 Lines
View Options

lib/libc/sys/poll.c

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Lines
KDB opt_global.h KDB opt_global.h
KDB_TRACE opt_kdb.h KDB_TRACE opt_kdb.h
KDB_UNATTENDED opt_kdb.h KDB_UNATTENDED opt_kdb.h
KLD_DEBUG opt_kld.h KLD_DEBUG opt_kld.h
SYSCTL_DEBUG opt_sysctl.h SYSCTL_DEBUG opt_sysctl.h
EARLY_PRINTF opt_global.h EARLY_PRINTF opt_global.h
TEXTDUMP_PREFERRED opt_ddb.h TEXTDUMP_PREFERRED opt_ddb.h
TEXTDUMP_VERBOSE opt_ddb.h TEXTDUMP_VERBOSE opt_ddb.h
NUM_CORES opt_global.h
sjgUnsubmitted
Not Done
Inline Actions

I know NUM_CORES makes sense given the code in kern_sig,c
but NUM_CORE_FILES might be more meaningful here?

sjg: I know NUM_CORES makes sense given the code in kern_sig,c but NUM_CORE_FILES might be more…
# Miscellaneous options. # Miscellaneous options.
ADAPTIVE_LOCKMGRS ADAPTIVE_LOCKMGRS
ALQ ALQ
ALTERA_SDCARD_FAST_SIM opt_altera_sdcard.h ALTERA_SDCARD_FAST_SIM opt_altera_sdcard.h
ATSE_CFI_HACK opt_cfi.h ATSE_CFI_HACK opt_cfi.h
AUDIT opt_global.h AUDIT opt_global.h
BOOTHOWTO opt_global.h BOOTHOWTO opt_global.h
▲ Show 20 Lines • Show All 912 Lines • Show Last 20 Lines
View Options

lib/libc/sys/ppoll.c

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Lines
KDB opt_global.h KDB opt_global.h
KDB_TRACE opt_kdb.h KDB_TRACE opt_kdb.h
KDB_UNATTENDED opt_kdb.h KDB_UNATTENDED opt_kdb.h
KLD_DEBUG opt_kld.h KLD_DEBUG opt_kld.h
SYSCTL_DEBUG opt_sysctl.h SYSCTL_DEBUG opt_sysctl.h
EARLY_PRINTF opt_global.h EARLY_PRINTF opt_global.h
TEXTDUMP_PREFERRED opt_ddb.h TEXTDUMP_PREFERRED opt_ddb.h
TEXTDUMP_VERBOSE opt_ddb.h TEXTDUMP_VERBOSE opt_ddb.h
NUM_CORES opt_global.h
sjgUnsubmitted
Not Done
Inline Actions

I know NUM_CORES makes sense given the code in kern_sig,c
but NUM_CORE_FILES might be more meaningful here?

sjg: I know NUM_CORES makes sense given the code in kern_sig,c but NUM_CORE_FILES might be more…
# Miscellaneous options. # Miscellaneous options.
ADAPTIVE_LOCKMGRS ADAPTIVE_LOCKMGRS
ALQ ALQ
ALTERA_SDCARD_FAST_SIM opt_altera_sdcard.h ALTERA_SDCARD_FAST_SIM opt_altera_sdcard.h
ATSE_CFI_HACK opt_cfi.h ATSE_CFI_HACK opt_cfi.h
AUDIT opt_global.h AUDIT opt_global.h
BOOTHOWTO opt_global.h BOOTHOWTO opt_global.h
▲ Show 20 Lines • Show All 912 Lines • Show Last 20 Lines
View Options

lib/libc/tests/secure/Makefile

Loading...
View Options

lib/libc/tests/secure/fortify_poll_test.c

Loading...
View Options

lib/libc/tests/secure/fortify_stdio_test.c

Loading...
View Options

lib/libc/tests/secure/fortify_string_test.c

Loading...
View Options

lib/libc/tests/secure/fortify_strings_test.c

Loading...
View Options

lib/libc/tests/secure/fortify_unistd_test.c

Loading...
View Options

lib/libc/tests/secure/generate-fortify-tests.lua

Loading...
View Options

sys/sys/poll.h

Loading...