Page MenuHomeFreeBSD
Differential D45738

libc: add memset test for int-to-char conversion
ClosedPublic
Actions

Authored by strajabot on Jun 25 2024, 9:30 PM.
Tags
None
Referenced Files
F163592559: D45738.diff
Fri, Jul 24, 7:20 PM
Unknown Object (File)
Mon, Jul 20, 10:01 PM
Unknown Object (File)
Mon, Jul 20, 12:06 PM
Unknown Object (File)
Mon, Jul 20, 1:47 AM
Unknown Object (File)
Sat, Jul 18, 9:51 AM
Unknown Object (File)
Sat, Jul 18, 3:26 AM
Unknown Object (File)
Thu, Jul 16, 5:53 PM
Unknown Object (File)
Thu, Jul 16, 12:50 AM
View All Files
Subscribers
imp

Details

Reviewers
fuz
emaste
Commits
rGf0d1236f0fc9: libc: Add memset test for int-to-char conversion
Summary

Test case to check if an implementation of memset correctly
handles the value passed being wider than a byte

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 58357
Build 55245: arc lint + arc unit

Event Timeline

strajabot created this revision.Jun 25 2024, 9:30 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 25 2024, 9:30 PM
strajabot requested review of this revision.Jun 25 2024, 9:30 PM
Harbormaster completed remote builds in B58350: Diff 140242.Jun 25 2024, 9:31 PM
strajabot updated this revision to Diff 140269.Jun 26 2024, 1:38 PM

Larger buffer size better tests how the parameter is handled

Harbormaster completed remote builds in B58357: Diff 140269.Jun 26 2024, 1:38 PM
fuz added a comment.Jun 26 2024, 4:10 PM

Test looks reasonable. Were you able to trigger test suite failure with your broken memset?

lib/libc/tests/string/memset_test.c
6–26

No need to put the full license text in if you already have a SPDX identifier.

strajabot added a comment.Jun 28 2024, 11:20 PM

Yes, the test fails with the broken memset, and passes with the fixed version

strajabot updated this revision to Diff 140357.Jun 28 2024, 11:31 PM

Leave only the SPDX identifier and copyright

Harbormaster completed remote builds in B58392: Diff 140357.Jun 28 2024, 11:31 PM
fuz accepted this revision.Jun 29 2024, 7:51 AM

Looks reasonable. Still needs approval from a src committer.

This revision is now accepted and ready to land.Jun 29 2024, 7:51 AM
emaste accepted this revision.Jun 29 2024, 2:41 PM

Approved with a tiny style change that can be applied

lib/libc/tests/string/memset_test.c
19

style(9) wants spaces -- for (int i = 0; i < 64; i++) {

Closed by commit rGf0d1236f0fc9: libc: Add memset test for int-to-char conversion (authored by strajabot, committed by fuz). · Explain WhyJul 13 2024, 1:08 PM
This revision was automatically updated to reflect the committed changes.
fuz added a commit: rGf0d1236f0fc9: libc: Add memset test for int-to-char conversion.

Revision Contents
Changeset List

PathSize
lib/
libc/
tests/
string/
2 lines
50 lines

Diff 140269

View Options

lib/libc/tests/string/Makefile

Loading...
View Options

lib/libc/tests/string/memset_test.c

Loading...