Page MenuHomeFreeBSD

libc: add memset test for int-to-char conversion
AcceptedPublic

Authored by strajabot on Tue, Jun 25, 9:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 28, 4:44 PM
Unknown Object (File)
Thu, Jun 27, 2:47 PM
Subscribers

Details

Reviewers
fuz
emaste
Summary

Test case to check if an implementation of memset correctly
handles the value passed being wider than a byte

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 58350
Build 55238: arc lint + arc unit

Event Timeline

Larger buffer size better tests how the parameter is handled

Test looks reasonable. Were you able to trigger test suite failure with your broken memset?

lib/libc/tests/string/memset_test.c
5–25

No need to put the full license text in if you already have a SPDX identifier.

Yes, the test fails with the broken memset, and passes with the fixed version

Leave only the SPDX identifier and copyright

Looks reasonable. Still needs approval from a src committer.

This revision is now accepted and ready to land.Sat, Jun 29, 7:51 AM

Approved with a tiny style change that can be applied

lib/libc/tests/string/memset_test.c
19

style(9) wants spaces -- for (int i = 0; i < 64; i++) {