ClosedPublic
Actions

Authored by kevans on Jun 21 2024, 5:00 PM.

Details

Reviewers

kib
markj

Group Reviewers

Klara

Commits

rG1f155d48f878: include: ssp: fortify <sys/socket.h>

Summary

The entire recv*() implementation set is ripe for opportunities to
validate, so do what we can with what we have.

Sponsored by: Stormshield
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58295
Build 55183: arc lint + arc unit

Event Timeline

kevans created this revision.Jun 21 2024, 5:00 PM

Herald added subscribers: glebius, imp. · View Herald TranscriptJun 21 2024, 5:00 PM

kevans requested review of this revision.Jun 21 2024, 5:00 PM

Harbormaster completed remote builds in B58295: Diff 140087.Jun 21 2024, 5:00 PM

kevans added a parent revision: D45685: include: ssp: fortify <sys/select.h>.Jun 21 2024, 5:00 PM

markj accepted this revision as: markj.Jun 24 2024, 5:00 PM

markj added inline comments.

lib/libc/tests/secure/generate-fortify-tests.lua
92	Is this check redundant? I'd expect new_socket() to check that if needed.

This revision is now accepted and ready to land.Jun 24 2024, 5:00 PM

kevans added a child revision: D45940: include: de-macro __ssp_overlap(), improve semantics and checking.Jul 9 2024, 7:51 PM

kevans marked an inline comment as done.Jul 9 2024, 8:16 PM

kevans added inline comments.

lib/libc/tests/secure/generate-fortify-tests.lua
92	Indeed, new_socket() already does plenty to ensure that it hasn't failed.

Closed by commit rG1f155d48f878: include: ssp: fortify <sys/socket.h> (authored by kevans). · Explain WhyJul 13 2024, 5:23 AM

This revision was automatically updated to reflect the committed changes.

kevans marked an inline comment as done.

kevans added a commit: rG1f155d48f878: include: ssp: fortify <sys/socket.h>.

Revision Contents
Changeset List

Path

Size

include/

ssp/

Makefile

4 lines

socket.h

123 lines

lib/

libc/

sys/

recv.c

3 lines

recvfrom.c

3 lines

recvmsg.c

3 lines

tests/

secure/

Makefile

1 line

fortify_poll_test.c

fortify_random_test.c

fortify_select_test.c

fortify_socket_test.c

fortify_stdio_test.c

fortify_stdlib_test.c

fortify_string_test.c

fortify_strings_test.c

fortify_uio_test.c

fortify_unistd_test.c

fortify_wchar_test.c

generate-fortify-tests.lua

240 lines

libsys/

recvmmsg.c

5 lines

sys/

socket.h

4 lines

Diff 140087

View Options

include/ssp/Makefile

View Options

include/ssp/socket.h

View Options

lib/libc/sys/recv.c

View Options

lib/libc/sys/recvfrom.c

View Options

lib/libc/sys/recvmsg.c

View Options

lib/libc/tests/secure/Makefile

View Options

lib/libc/tests/secure/fortify_poll_test.c

View Options

lib/libc/tests/secure/fortify_random_test.c

View Options

lib/libc/tests/secure/fortify_select_test.c

View Options

lib/libc/tests/secure/fortify_socket_test.c

View Options

lib/libc/tests/secure/fortify_stdio_test.c

View Options

lib/libc/tests/secure/fortify_stdlib_test.c

View Options

lib/libc/tests/secure/fortify_string_test.c

View Options

lib/libc/tests/secure/fortify_strings_test.c

View Options

lib/libc/tests/secure/fortify_uio_test.c

View Options

lib/libc/tests/secure/fortify_unistd_test.c

View Options

lib/libc/tests/secure/fortify_wchar_test.c

View Options

lib/libc/tests/secure/generate-fortify-tests.lua

View Options

lib/libsys/recvmmsg.c

View Options

include: ssp: fortify <sys/socket.h>ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 140087

include/ssp/Makefile

include/ssp/socket.h

lib/libc/sys/recv.c

lib/libc/sys/recvfrom.c

lib/libc/sys/recvmsg.c

lib/libc/tests/secure/Makefile

lib/libc/tests/secure/fortify_poll_test.c

lib/libc/tests/secure/fortify_random_test.c

lib/libc/tests/secure/fortify_select_test.c

lib/libc/tests/secure/fortify_socket_test.c

lib/libc/tests/secure/fortify_stdio_test.c

lib/libc/tests/secure/fortify_stdlib_test.c

lib/libc/tests/secure/fortify_string_test.c

lib/libc/tests/secure/fortify_strings_test.c

lib/libc/tests/secure/fortify_uio_test.c

lib/libc/tests/secure/fortify_unistd_test.c

lib/libc/tests/secure/fortify_wchar_test.c

lib/libc/tests/secure/generate-fortify-tests.lua

lib/libsys/recvmmsg.c

sys/sys/socket.h

include: ssp: fortify <sys/socket.h>
ClosedPublic
Actions

Revision Contents
Changeset List