Page MenuHomeFreeBSD

sockstat: Fix segfault when peer has no pid
AcceptedPublic

Authored by dan.mcgregor_usask.ca on May 10 2024, 2:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 13, 3:51 AM
Unknown Object (File)
Thu, Aug 13, 1:23 AM
Unknown Object (File)
Mon, Aug 10, 11:45 AM
Unknown Object (File)
Sat, Aug 8, 3:58 PM
Unknown Object (File)
Sat, Aug 8, 6:03 AM
Unknown Object (File)
Fri, Aug 7, 10:52 PM
Unknown Object (File)
Mon, Aug 3, 7:49 AM
Unknown Object (File)
Mon, Aug 3, 3:49 AM
Subscribers

Details

Summary

If a dgram socket's remote end is the kernel, there may not
be a file associated with it. I've seen this with gssd's kernel
rpc socket. Arguably the kernel should do something better, but
for now handle the possibility.

Signed-off-by: Dan McGregor <dan.mcgregor@usask.ca>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 57649
Build 54537: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 10 2024, 6:12 PM

Thanks, @tuexen and @emaste. This does affect my NFS server on every version I've tried in the 14-STABLE or 15-CURRENT series. 13.3 is unaffected. Looks like everything since commit a83d596f434f in 2022.

I have no commit bit, so if somebody could commit this it'd be appreciated.