Page MenuHomeFreeBSD
Differential D45137

sound: Add missing oss_mixerinfo devnode and legacy_device fields
ClosedPublic
Actions

Authored by christos on May 8 2024, 11:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 29, 1:39 AM
Unknown Object (File)
Thu, Aug 27, 6:51 PM
Unknown Object (File)
Sun, Aug 23, 12:42 PM
Unknown Object (File)
Sat, Aug 15, 6:29 PM
Unknown Object (File)
Sat, Aug 15, 9:54 AM
Unknown Object (File)
Thu, Aug 13, 1:55 PM
Unknown Object (File)
Thu, Aug 13, 11:41 AM
Unknown Object (File)
Thu, Aug 13, 12:32 AM
View All Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rG8bd14f511efa: sound: Add missing oss_mixerinfo devnode and legacy_device fields
rGe6df8c379b0c: sound: Add missing oss_mixerinfo devnode and legacy_device fields
Summary

They are missing from soundcard.h and are in fact used by some
applications, such as OSS' ossinfo(1):
http://manuals.opensound.com/developer/ossinfo.c.html

The new size for filler is chosen according to the most recent official
version of soundcard.h, which includes those 2 fields.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57631
Build 54519: arc lint + arc unit

Event Timeline

christos created this revision.May 8 2024, 11:08 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 8 2024, 11:08 PM
christos requested review of this revision.May 8 2024, 11:08 PM
Harbormaster completed remote builds in B57629: Diff 138274.May 8 2024, 11:08 PM
emaste added inline comments.May 8 2024, 11:11 PM
sys/sys/soundcard.h
1928–1930

I'd imagine the new fields should reduce the size of filler[]

christos added inline comments.May 8 2024, 11:13 PM
sys/sys/soundcard.h
1928–1930

I know but I am not sure what the new size should be. Maybe 254 - sizeof(oss_devnode_t) - sizeof(int)?

christos added inline comments.May 8 2024, 11:21 PM
sys/sys/soundcard.h
1928–1930

Okay, according to the latest version of soundcard.h I can find in the OSS website, filler's size is 254 with these fileds added.

Also I think it might be a good idea to look into porting to the most recent soundcard.h over to FreeBSD.

christos added inline comments.May 8 2024, 11:23 PM
sys/sys/soundcard.h
1928–1930

Sorry, I meant to write 245.

christos edited the summary of this revision. (Show Details)May 8 2024, 11:29 PM
christos updated this revision to Diff 138276.May 8 2024, 11:29 PM
christos marked an inline comment as done.

Update commit message and filler size according to most recent soundcard.h
version.

Harbormaster completed remote builds in B57631: Diff 138276.May 8 2024, 11:29 PM
christos retitled this revision from sound: Add missing oss_mixerinfo devnode and real_device fields to sound: Add missing oss_mixerinfo devnode and legacy_device fields.May 8 2024, 11:36 PM
christos edited the summary of this revision. (Show Details)
christos updated this revision to Diff 138277.May 8 2024, 11:36 PM

s/real_device/legacy_device/

Harbormaster completed remote builds in B57632: Diff 138277.May 8 2024, 11:36 PM
dev_submerge.ch accepted this revision.May 9 2024, 4:15 PM
This revision is now accepted and ready to land.May 9 2024, 4:15 PM
Closed by commit rGe6df8c379b0c: sound: Add missing oss_mixerinfo devnode and legacy_device fields (authored by christos). · Explain WhyMay 9 2024, 7:09 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rGe6df8c379b0c: sound: Add missing oss_mixerinfo devnode and legacy_device fields.
christos added a commit: rG8bd14f511efa: sound: Add missing oss_mixerinfo devnode and legacy_device fields.May 17 2024, 7:34 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
11 lines
sys/
4 lines

Diff 138276

View Options

sys/dev/sound/pcm/mixer.c

Loading...
View Options

sys/sys/soundcard.h

Loading...