Page MenuHomeFreeBSD
Differential D44840

sound: Call device_get_name() and device_get_unit() only once in mixer_init()
ClosedPublic
Actions

Authored by christos on Apr 18 2024, 5:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 15, 1:15 PM
Unknown Object (File)
Tue, May 14, 4:13 AM
Unknown Object (File)
Thu, May 9, 11:25 PM
Unknown Object (File)
Fri, Apr 26, 3:19 AM
Unknown Object (File)
Apr 21 2024, 5:22 PM
Unknown Object (File)
Apr 18 2024, 10:30 PM
Unknown Object (File)
Apr 18 2024, 8:50 PM
Subscribers
imp

Details

Reviewers
markj
emaste
Commits
rG69707d9f5091: sound: Call device_get_name() and device_get_unit() only once in mixer_init()
rG41ab202ff74e: sound: Call device_get_name() and device_get_unit() only once in mixer_init()
Summary

No functional change intended.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57197
Build 54085: arc lint + arc unit

Event Timeline

christos created this revision.Apr 18 2024, 5:42 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 18 2024, 5:42 PM
christos requested review of this revision.Apr 18 2024, 5:42 PM
Harbormaster completed remote builds in B57179: Diff 137318.Apr 18 2024, 5:42 PM
emaste added inline comments.Apr 18 2024, 5:51 PM
sys/dev/sound/pcm/mixer.c
736–740

probably swap the order here just for consistency (we think of <name><unit>)

christos updated this revision to Diff 137337.Apr 18 2024, 6:05 PM
christos marked an inline comment as done.

Address Ed's comment.

Harbormaster completed remote builds in B57197: Diff 137337.Apr 18 2024, 6:05 PM
emaste accepted this revision.Apr 18 2024, 6:16 PM
This revision is now accepted and ready to land.Apr 18 2024, 6:16 PM
markj accepted this revision.Apr 18 2024, 7:10 PM
Closed by commit rG41ab202ff74e: sound: Call device_get_name() and device_get_unit() only once in mixer_init() (authored by christos). · Explain WhyApr 18 2024, 8:36 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG41ab202ff74e: sound: Call device_get_name() and device_get_unit() only once in mixer_init().
christos added a commit: rG69707d9f5091: sound: Call device_get_name() and device_get_unit() only once in mixer_init().Fri, May 17, 7:31 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
12 lines

Diff 137337

View Options

sys/dev/sound/pcm/mixer.c

Loading...