Paths

Table of Contentst

Differential D44667

vm_reserv_reclaim_contig: Return NULL not false
ClosedPublic
Actions

Authored by mchoo on Apr 7 2024, 5:44 AM.

Tags

Referenced Files

	Unknown Object (File)
	Wed, Sep 9, 9:30 PM

	Unknown Object (File)
	Wed, Sep 9, 2:20 PM

	Unknown Object (File)
	Fri, Sep 4, 1:02 AM

	Unknown Object (File)
	Thu, Sep 3, 3:46 AM

	Unknown Object (File)
	Wed, Sep 2, 11:41 PM

	Unknown Object (File)
	Wed, Sep 2, 9:35 PM

	Unknown Object (File)
	Wed, Sep 2, 12:44 AM

	Unknown Object (File)
	Tue, Sep 1, 3:27 AM

Subscribers

Contributor Reviews (src)

Details

Reviewers

markj
zlei
dougm

Group Reviewers

Contributor Reviews (src)

Commits

rG1f85f062768d: vm_reserv_reclaim_contig: Return NULL not false
rG989a2cf19d05: vm_reserv_reclaim_contig: Return NULL not false

Summary

Since vm_page_t is a typedef of a pointer to struct vm_page, returning
false is undefined.

Test Plan

make buildkernel

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 56953
Build 53841: arc lint + arc unit

Event Timeline

mchoo created this revision.Apr 7 2024, 5:44 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 7 2024, 5:44 AM

mchoo requested review of this revision.Apr 7 2024, 5:44 AM

Harbormaster completed remote builds in B56953: Diff 136640.Apr 7 2024, 5:44 AM

mchoo edited the test plan for this revision. (Show Details)Apr 7 2024, 5:45 AM

mchoo added a reviewer: Contributor Reviews (src).

mchoo added a project: Contributor Reviews (src).

mchoo added a subscriber: Contributor Reviews (src).

I'm not completely familar with FreeBSD's virtual memory system. But it seems the comment still doesn't match the code. Doesn't it return m_ret when the reclaim is successful and null when failed?

lwhsu added a reviewer: markj.Apr 7 2024, 6:10 AM

Looks good to me.

sys/vm/vm_reserv.c
1195	English is not my tone but it sounds 'or' is more appropriate.
1197	The return type was changed from `bool` to `vm_page_t` by commit 0d5fac287294 (vm: alloc pages from reserv before breaking it) but the comments are left unchanged.

This revision is now accepted and ready to land.Apr 10 2024, 8:56 AM

zlei added a reviewer: dougm.Apr 10 2024, 9:11 AM

dougm accepted this revision.Apr 10 2024, 9:40 AM

Closed by commit rG989a2cf19d05: vm_reserv_reclaim_contig: Return NULL not false (authored by mchoo, committed by markj). · Explain WhyApr 10 2024, 12:52 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG989a2cf19d05: vm_reserv_reclaim_contig: Return NULL not false.

markj added a commit: rG1f85f062768d: vm_reserv_reclaim_contig: Return NULL not false.Apr 17 2024, 2:35 PM

Revision Contents
Changeset List

Path

Size

sys/

vm/

4 lines

Diff 136640

sys/vm/vm_reserv.c

Loading...