Page MenuHomeFreeBSD
Differential D44636

tarfs.5: Provide some guidance on zstd frame sizes
ClosedPublic
Actions

Authored by markj on Apr 4 2024, 4:30 PM.
Tags
None
Referenced Files
F175845090: D44636.id136563.diff
Tue, Oct 13, 8:20 PM
F175845086: D44636.id136540.diff
Tue, Oct 13, 8:19 PM
F175845079: D44636.diff
Tue, Oct 13, 8:19 PM
Unknown Object (File)
Mon, Oct 5, 10:01 PM
Unknown Object (File)
Mon, Oct 5, 5:58 PM
Unknown Object (File)
Mon, Oct 5, 4:16 PM
Unknown Object (File)
Mon, Oct 5, 1:42 AM
Unknown Object (File)
Mon, Oct 5, 12:38 AM
View All Files
Subscribers
imp

Details

Reviewers
emaste
des
kib
Commits
rG753de7251761: tarfs.5: Provide some guidance on zstd frame sizes
rGfd56d2472586: tarfs.5: Provide some guidance on zstd frame sizes
Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 56915
Build 53803: arc lint + arc unit

Event Timeline

markj created this revision.Apr 4 2024, 4:30 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 4 2024, 4:30 PM
markj requested review of this revision.Apr 4 2024, 4:30 PM
Harbormaster completed remote builds in B56915: Diff 136540.Apr 4 2024, 4:30 PM
emaste accepted this revision.Apr 4 2024, 5:19 PM

This LGTM thanks

This revision is now accepted and ready to land.Apr 4 2024, 5:19 PM
des added inline comments.Apr 5 2024, 11:19 AM
share/man/man5/tarfs.5
83

Smaller frames also require more memory since we keep an index of them.

markj updated this revision to Diff 136563.Apr 5 2024, 12:10 PM

Note that smaller frames imply more kernel memory usage.

This revision now requires review to proceed.Apr 5 2024, 12:10 PM
Harbormaster completed remote builds in B56925: Diff 136563.Apr 5 2024, 12:11 PM
emaste accepted this revision.Apr 5 2024, 12:21 PM
This revision is now accepted and ready to land.Apr 5 2024, 12:21 PM
des accepted this revision.Apr 5 2024, 3:25 PM
Closed by commit rGfd56d2472586: tarfs.5: Provide some guidance on zstd frame sizes (authored by markj). · Explain WhyApr 5 2024, 3:44 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGfd56d2472586: tarfs.5: Provide some guidance on zstd frame sizes.
markj added a commit: rG753de7251761: tarfs.5: Provide some guidance on zstd frame sizes.Apr 22 2024, 1:49 PM

Revision Contents
Changeset List

PathSize
share/
man/
man5/
9 lines

Diff 136540

View Options

share/man/man5/tarfs.5

Loading...