nvmecontrol: Display additional Fabrics-related fields for cdata
ClosedPublic
Actions

Authored by jhb on Mar 20 2024, 11:23 PM.

Details

Reviewers

imp
chuck

Commits

rG7e771c225d9c: nvmecontrol: Display additional Fabrics-related fields for cdata
rGacbc176c3dfd: nvmecontrol: Display additional Fabrics-related fields for cdata

Summary

Some of these fields are specific to Fabrics controllers (such as the
size of capsules) while other fields are shared with PCI-e
controllers, but are more relevant for Fabrics controllers (such as
KeepAlive timer properties).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Mar 20 2024, 11:23 PM

Herald added a subscriber: dab. · View Herald TranscriptMar 20 2024, 11:23 PM

jhb requested review of this revision.Mar 20 2024, 11:23 PM

jhb added a parent revision: D44448: nvme: Add NVMe over Fabrics fields to nvme_controller_data.

Harbormaster completed remote builds in B56720: Diff 136008.Mar 20 2024, 11:24 PM

imp accepted this revision.Mar 21 2024, 9:18 AM

imp added inline comments.

sbin/nvmecontrol/identify_ext.c
154	Do we have #defines for these?

This revision is now accepted and ready to land.Mar 21 2024, 9:18 AM

jhb added inline comments.Mar 21 2024, 5:45 PM

sbin/nvmecontrol/identify_ext.c
154	We do not currently.

imp added inline comments.Mar 22 2024, 9:16 PM

sbin/nvmecontrol/identify_ext.c
154	Ok

Closed by commit rGacbc176c3dfd: nvmecontrol: Display additional Fabrics-related fields for cdata (authored by jhb). · Explain WhyMar 23 2024, 12:27 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGacbc176c3dfd: nvmecontrol: Display additional Fabrics-related fields for cdata.

jhb added a commit: rG7e771c225d9c: nvmecontrol: Display additional Fabrics-related fields for cdata.Aug 27 2024, 1:07 AM

Revision Contents
Changeset List

Path

Size

sbin/

nvmecontrol/

identify_ext.c

51 lines

Diff 136120

View Options

sbin/nvmecontrol/identify_ext.c

nvmecontrol: Display additional Fabrics-related fields for cdataClosedPublicActions