Page MenuHomeFreeBSD
Differential D44078

Update to FreeBSD handbook: virtualization chapter
Needs ReviewPublic
Actions

Authored by freebsd_ny-central.org on Feb 25 2024, 8:39 AM.
Tags
Referenced Files
F83498883: D44078.diff
Sat, May 11, 8:54 AM
Unknown Object (File)
Tue, May 7, 6:51 AM
Unknown Object (File)
Sun, Apr 28, 9:59 AM
Unknown Object (File)
Fri, Apr 26, 3:42 AM
Unknown Object (File)
Fri, Apr 26, 3:42 AM
Unknown Object (File)
Fri, Apr 26, 3:42 AM
Unknown Object (File)
Fri, Apr 26, 3:42 AM
Unknown Object (File)
Fri, Apr 26, 3:42 AM
View All 15 Files
Subscribers
emaste
pauamma_gundo.com

Details

Reviewers
jrm
pauamma_gundo.com
Group Reviewers
docs
Summary

Expanding documentation around bhyve

  • snapshot feature (experimental)
  • additional notice about persisting and changing network configuration and potential for locking oneself out
  • jailing bhyve

I should probably add, that I'm more than willing to remove the part on snapshots, because it's certainly very experimental. On the other hand, this might invite more people to test and try things out.

Feedback - as usual - very welcome!

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

freebsd_ny-central.org requested review of this revision.Feb 25 2024, 8:39 AM
freebsd_ny-central.org created this revision.
freebsd_ny-central.org edited the summary of this revision. (Show Details)Feb 25 2024, 8:41 AM
emaste added a subscriber: emaste.Feb 26 2024, 11:40 PM
emaste added inline comments.
documentation/content/en/books/handbook/virtualization/_index.adoc
500–501

We mention Intel and AMD; should we reference Arm as well?

freebsd_ny-central.org updated this revision to Diff 135069.Feb 27 2024, 4:39 PM

Valid point on ARM - I've added a suggestion on ARM though I ain't an expert on the topic.
I got those infos from here: https://cgit.freebsd.org/src/commit/?id=47e073941f4e

freebsd_ny-central.org marked an inline comment as done.Feb 27 2024, 4:39 PM
freebsd_ny-central.org added inline comments.
documentation/content/en/books/handbook/virtualization/_index.adoc
500–501

Actually, now rereading what I wrote... this makes no sense. I'll change this again.

freebsd_ny-central.org updated this revision to Diff 135070.Feb 27 2024, 4:44 PM

Restructured into a bullet point list; certainly better to read - hope the content is correct though.

pauamma_gundo.com requested changes to this revision.Mar 3 2024, 3:50 AM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.

Bunch of small things I spotted.

documentation/content/en/books/handbook/virtualization/_index.adoc
893
898

2nd-person pronoun use is discouraged.

937
944
988
995
1003
1011
1019

Shouldn't it be the same as the host's?

1024

Also, with 13.3 days from expected release, maybe wait a bit and use that as an example, for future-proofing?

1057
1062
1074
1135
1136
1181
1227
1232
1234
1247

For consistency with the actual examples

1267–1269

Why not pkg -j bhyve install bhyve-firmware?

This revision now requires changes to proceed.Mar 3 2024, 3:50 AM
freebsd_ny-central.org updated this revision to Diff 135555.Mar 8 2024, 9:23 PM
freebsd_ny-central.org marked 20 inline comments as done.

Updated after feedback. Thanks for the great inputs!

freebsd_ny-central.org marked an inline comment as done.Mar 8 2024, 9:33 PM
pauamma_gundo.com added a comment.Mar 13 2024, 4:46 AM

A few typos remain, but getting close, I think.

documentation/content/en/books/handbook/virtualization/_index.adoc
893

"additionally" and "reasonably" misspelled.

937

Spurious "if you"

freebsd_ny-central.org updated this revision to Diff 135820.Mar 16 2024, 12:34 PM

Thanks for spotting those. I really need to run a spellcheck before I submit things. Apologies for the extra round.
Added additional typo and comma fixes and improvements for brevity.

freebsd_ny-central.org marked 2 inline comments as done.Mar 16 2024, 12:35 PM
pauamma_gundo.com accepted this revision.Mar 16 2024, 5:27 PM
This revision is now accepted and ready to land.Mar 16 2024, 5:27 PM
jrm added inline comments.Mar 18 2024, 3:18 PM
documentation/content/en/books/handbook/virtualization/_index.adoc
562
775

Does this sound clearer?

800
801–802

I removed instances of the second person as Pau Amma requested in other reviews and suggested an alternative wording.

809
850
853
858
884
892
893
913
926–936

Would it be better to link to Quick Start section of the Updating and Upgrading FreeBSD chapter? The shell source at the top is nearly the same as here.

freebsd_ny-central.org updated this revision to Diff 137750.Sat, Apr 27, 1:46 PM

Thanks for the feedback. I've merged all suggested changes and also

  • removed a few more "you" statements to a more neutral version
  • added a note/recommendation on using UEFI vars file w/ Linux to prevent having to rename boot files
This revision now requires review to proceed.Sat, Apr 27, 1:46 PM
freebsd_ny-central.org marked 13 inline comments as done.Sat, Apr 27, 1:48 PM

Revision Contents
Changeset List

PathSize
documentation/
content/
en/
books/
handbook/
virtualization/
596 lines

Diff 135069

View Options

documentation/content/en/books/handbook/virtualization/_index.adoc

Loading...