Page MenuHomeFreeBSD

Update to FreeBSD handbook: virtualization chapter
Needs ReviewPublic

Authored by freebsd_ny-central.org on Feb 25 2024, 8:39 AM.
Tags
Referenced Files
Unknown Object (File)
Tue, May 7, 6:51 AM
Unknown Object (File)
Sun, Apr 28, 9:59 AM
Unknown Object (File)
Fri, Apr 26, 3:42 AM
Unknown Object (File)
Fri, Apr 26, 3:42 AM
Unknown Object (File)
Fri, Apr 26, 3:42 AM
Unknown Object (File)
Fri, Apr 26, 3:42 AM
Unknown Object (File)
Fri, Apr 26, 3:42 AM
Unknown Object (File)
Fri, Apr 26, 3:42 AM

Details

Reviewers
jrm
pauamma_gundo.com
Group Reviewers
docs
Summary

Expanding documentation around bhyve

  • snapshot feature (experimental)
  • additional notice about persisting and changing network configuration and potential for locking oneself out
  • jailing bhyve

I should probably add, that I'm more than willing to remove the part on snapshots, because it's certainly very experimental. On the other hand, this might invite more people to test and try things out.

Feedback - as usual - very welcome!

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste added inline comments.
documentation/content/en/books/handbook/virtualization/_index.adoc
500–506

We mention Intel and AMD; should we reference Arm as well?

Valid point on ARM - I've added a suggestion on ARM though I ain't an expert on the topic.
I got those infos from here: https://cgit.freebsd.org/src/commit/?id=47e073941f4e

freebsd_ny-central.org added inline comments.
documentation/content/en/books/handbook/virtualization/_index.adoc
500–506

Actually, now rereading what I wrote... this makes no sense. I'll change this again.

Restructured into a bullet point list; certainly better to read - hope the content is correct though.

Bunch of small things I spotted.

documentation/content/en/books/handbook/virtualization/_index.adoc
898
903

2nd-person pronoun use is discouraged.

942
949
993
1000
1008
1016
1024

Shouldn't it be the same as the host's?

1029

Also, with 13.3 days from expected release, maybe wait a bit and use that as an example, for future-proofing?

1062
1067
1079
1140
1141
1186
1232
1237
1239
1252

For consistency with the actual examples

1272–1274

Why not pkg -j bhyve install bhyve-firmware?

This revision now requires changes to proceed.Mar 3 2024, 3:50 AM
freebsd_ny-central.org marked 20 inline comments as done.

Updated after feedback. Thanks for the great inputs!

A few typos remain, but getting close, I think.

documentation/content/en/books/handbook/virtualization/_index.adoc
898

"additionally" and "reasonably" misspelled.

942

Spurious "if you"

Thanks for spotting those. I really need to run a spellcheck before I submit things. Apologies for the extra round.
Added additional typo and comma fixes and improvements for brevity.

This revision is now accepted and ready to land.Mar 16 2024, 5:27 PM
documentation/content/en/books/handbook/virtualization/_index.adoc
567
780

Does this sound clearer?

805
806–807

I removed instances of the second person as Pau Amma requested in other reviews and suggested an alternative wording.

814
855
858
863
889
897
898
918
931–941

Would it be better to link to Quick Start section of the Updating and Upgrading FreeBSD chapter? The shell source at the top is nearly the same as here.

Thanks for the feedback. I've merged all suggested changes and also

  • removed a few more "you" statements to a more neutral version
  • added a note/recommendation on using UEFI vars file w/ Linux to prevent having to rename boot files
This revision now requires review to proceed.Sat, Apr 27, 1:46 PM